Skip to content

Adapt troubleshooting options to Rails component#6142

Merged
aduth merged 11 commits intomainfrom
aduth-troubleshooting-options
Apr 4, 2022
Merged

Adapt troubleshooting options to Rails component#6142
aduth merged 11 commits intomainfrom
aduth-troubleshooting-options

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Apr 4, 2022

Why:

aduth added 5 commits April 4, 2022 09:57
Dependency of TroubleshootingOptionsComponent
Internal, Components, Improve developer experience around status page troubleshooting options
<% end %>
</ul>
<% end %>
<%= render TroubleshootingOptionsComponent.new do |c| %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't yet remove the partial, since it's used in quite a few places that would need to be updated. I could do it here, but figured it better to limit the size of the changes.

aduth added 6 commits April 4, 2022 10:35
changelog: Internal, Components, Improve developer experience around status page troubleshooting options
While it wouldn't be an issue in practice, specs are set up to assume "nil" can be passed explicitly. Also better matches previous behavior
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit f161415 into main Apr 4, 2022
@aduth aduth deleted the aduth-troubleshooting-options branch April 4, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants