Adapt troubleshooting options to Rails component#6142
Merged
Conversation
Dependency of TroubleshootingOptionsComponent
Internal, Components, Improve developer experience around status page troubleshooting options
aduth
commented
Apr 4, 2022
| <% end %> | ||
| </ul> | ||
| <% end %> | ||
| <%= render TroubleshootingOptionsComponent.new do |c| %> |
Contributor
Author
There was a problem hiding this comment.
This doesn't yet remove the partial, since it's used in quite a few places that would need to be updated. I could do it here, but figured it better to limit the size of the changes.
changelog: Internal, Components, Improve developer experience around status page troubleshooting options
While it wouldn't be an issue in practice, specs are set up to assume "nil" can be passed explicitly. Also better matches previous behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: