Revert tab placement change for password toggle checkbox#6185
Merged
Conversation
**Why**: Since it may have a negative impact on form usability, revert until we have a chance to think about this more holistically. [skip changelog]
aduth
force-pushed
the
aduth-revert-pw-toggle-tab
branch
from
b6906a6 to
73d6239
Compare
zachmargolis
approved these changes
Apr 12, 2022
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, I was gonna ask if we can remove the toggle_position option entirely but it looks like we use it for CSS classes only still, we just don't need to rearrange the DOM for it
Contributor
Author
Yeah, we still have styles which are applied depending on position, so the option will need to stay. |
zachmargolis
pushed a commit
that referenced
this pull request
Apr 12, 2022
**Why**: Since it may have a negative impact on form usability, revert until we have a chance to think about this more holistically. [skip changelog] (cherry picked from commit 22c3d73)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #6081
Why: Since it may have a negative impact on form usability, revert until we have a chance to think about this more holistically.