Document additional analytics events (LG-5924)#6149
Merged
zachmargolis merged 9 commits intomainfrom Apr 5, 2022
Merged
Conversation
changelog: Internal, Documentation, Document additional analytics events
aduth
approved these changes
Apr 5, 2022
| stored_location:, | ||
| sp_request_url_present:, | ||
| remember_device:, | ||
| **extra |
Contributor
Author
There was a problem hiding this comment.
no, but because we got burned by missing it one place, I made us require it for all methods in #6052. Maybe there's some additional documentation param we could no like a @noextra or something when we know but currently there's no exceptions to our lint on requiring that
Contributor
There was a problem hiding this comment.
Gotcha, I thought that sounded familiar, but I swear I had seen another event where we weren't using **extra. Looking again, I don't see it, so must have been imagining things 🤷
Contributor
Author
There was a problem hiding this comment.
You might have seen a zero-param event (those get a free pass) or seen one of the PRs prior to that one 🤷
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This batch included
DOC_AUTHwhich runs through the FSM and gets to be many many different events, I opted to skip that for now and focus on the more mechanical translations