Add crossorigin script attribute for local development Webpack assets#6126
Merged
Add crossorigin script attribute for local development Webpack assets#6126
Conversation
**Why**: To prevent issues where React is unable to access error details in development mode, in combination with assets served via webpack-dev-server.
aduth
commented
Mar 30, 2022
aduth
changed the title
https: //github.com//pull/6126/files#r839008756 Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
changelog: Internal, Local Development, Fix cross-origin React errors when developing locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: To prevent issues where React is unable to access error details in development mode, in combination with assets served cross-origin via
webpack-dev-server.Steps to reproduce: Follow "Testing identity proofing" process to upload an error document to the document capture step. Without these changes, you would see a generic "technical difficulties" message.
Related docs: https://reactjs.org/docs/cross-origin-errors.html