Multiple addresses for listener 4 27 by soulxu · Pull Request #1 · soulxu/envoy

soulxu · 2022-05-09T06:44:17Z

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

) Signed-off-by: wbpcode <wbphub@live.com>

…xy#20551) The code was not accounting for parallel queries in this path. Also add more assertions to make similar issues easier to understand in the future. Signed-off-by: Matt Klein <mklein@lyft.com>

…nvoyproxy#20445) * Further abstraction ECDS config discovery header file to make it extendable to other filters. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

Fixing hostname issues for upstream HTTP/3. Consistently using correct SNI (configured or auto) as server ID and alt-svc origin everywhere. This also unfortunately required tweaking a LOT of integration tests, as it meant the hostname for SNI was pulled from host headers (as we auto-sni by default in integrationt tests) and HTTP/3 validates that hostname against the certs (test certs are for "foo.lyft.com" but default host for request headers was "host") Risk Level: Low (uptream HTTP/3) Testing: fixed a lot of integration tests. Docs Changes: n/a Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Risk Level: Low Testing: integration test Docs Changes: n/a Release Notes: inline Runtime guard: yes Fixes envoyproxy#20267 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Resource deletion for non wildcard resource types like eds and rds will only happen on parent resource deletion for both Sotw and Incremental variants. This PR clarifies it in doc. Risk Level: N/A Testing: N/A Docs Changes: N/A Release Notes:N/A Signed-off-by: Rama Chavali <rama.rao@salesforce.com>

…voyproxy#20555) Bumps [setuptools](https://github.com/pypa/setuptools) from 61.0.0 to 61.2.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v61.0.0...v61.2.0) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: rainingmaster <jinhua.tan@bytedance.com>

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

…roxy#20557) Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>

https://github.com/google/quiche/compare/b030612c6..fdf95d751 $ git log b030612c6..fdf95d751 --date=short --no-merges --format="%ad %al %s" 2022-03-28 birenroy Explicitly adds "host" to the set of accepted request headers, and allows "host" in place of ":authority". 2022-03-28 diannahu Allow NgHttp2Adapter to remove `sources_` map entries via CallbackVisitor. 2022-03-25 fayang Send connection close packet for QUIC_INVALID_VERSION, behind client_connection_option INVC. 2022-03-25 ramosalex Changed one assertion to use matchers instead of size and index check. 2022-03-25 diannahu Make oghttp2 reject connection-specific headers during header validation. 2022-03-25 haoyuewang Internal change 2022-03-24 fayang Automated g4 rollback of changelist 436769765. 2022-03-24 fayang Log QUIC_BUG if connection sends multiple connection closes. 2022-03-23 diannahu Fix oghttp2 to reject 204 responses with a body, even with no content-length header. 2022-03-23 fayang Flush creator after MaybeCoalescePacketOfHigherSpace. This would allow connection to coalesce HANDSHAKE + 1-RTT packets while there is an INITIAL in the coalescer. 2022-03-23 danzh Deprecate --gfe2_reloadable_flag_quic_pass_path_response_to_validator. 2022-03-23 fayang Reporting ACK delay based on packet receipt time (rather than packet process time). 2022-03-22 fayang On the server side, drop packets with changed server address silently. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: giantcroc <changran.wang@intel.com>

https://blog.bazel.build/2022/03/24/bazel-5.1.html Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

The last consumer of this was removed in the linked commit Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

…ariable (envoyproxy#20386) Signed-off-by: wbpcode <wbphub@live.com>

Signed-off-by: Felix Du <durd07@gmail.com>

…envoyproxy#20572) Bumps [flask](https://github.com/pallets/flask) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/pallets/flask/releases) - [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst) - [Commits](pallets/flask@2.0.3...2.1.0) --- updated-dependencies: - dependency-name: flask dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…xy#20556) Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES) - [Commits](sphinx-doc/sphinx@v4.4.0...v4.5.0) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…20579) Signed-off-by: He Jie Xu <hejie.xu@intel.com>

…envoyproxy#20488) Follow up on envoyproxy#20468 to future-proof against slow tests, by adding a default timeout to the raw connection driver This caught a whole bunch of tests which were waiting 15s for delay close. Risk Level: n/a (test only) Testing: CI Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

SupportsCustomResolversAsFallback has been failing locally for me because there's only a default resolver, so we use the configured failovers immediately. Fixing the test to handle that case Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

… it (envoyproxy#20571) Part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Risk Level: n/a (visibility only) part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

…0570) Signed-off-by: Greg Greenway <ggreenway@apple.com>

…proxy#20588) Part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

The `Content-Length` header will be added to the token request, which effectively disables `Transfer-Encoding: chunked`. Azure AD login.microsoftonline.com does not support chunked transfers and returns a 404. Risk Level: Low Testing: A test case has been added for the presence of the Content-Length header. Manual testing was done using a custom docker image with login.microsoftonline.com as the identity provider. The test setup is described in issue envoyproxy#20179. The custom docker image was built from commit db0b80b and is available at DockerHub as mhyllander/envoy:issue_20179. Docs Changes: N/A Release Notes: yes Platform Specific Features: N/A Fixes envoyproxy#20179 Signed-off-by: Magnus Hyllander <magnus.hyllander@hivestreaming.com>

Removing unnecessary public visibility from extensions. Changing the visibility rules of extensions to be visible from contrib and examples. We do this for the specific extensions which need it, but I'm comfortable leaving it as blanket visibility and it will avoid churn as other deps are needed. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Testing: ran against envoyproxy#20552 :-) Leaving those BUILD files in as example exemptions. Fixes envoyproxy#20589 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

…rt docs (envoyproxy#20582) Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

…_response_and_redirect (envoyproxy#21000) Commit Message: deprecate envoy_reloadable_features_http_ext_authz_do_not_skip_direct_response_and_redirect Fixes envoyproxy#20980 Signed-off-by: He Jie Xu <hejie.xu@intel.com>

This allows out-or-repo filters to use it. Signed-off-by: Greg Greenway <ggreenway@apple.com>

fixes envoyproxy#20979 Signed-off-by: giantcroc <changran.wang@intel.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

…roxy#20834) Risk Level: low Testing: new unit testing Docs Changes: n/a Release Notes: n/a Part of envoyproxy#20696 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

…ration_test (envoyproxy#20931) Some tests with giant request/response payload in multiplex_integration_tests.cc have been flaky at FakeHttpConnection::waitForNewStream() under TSAN because of the contention between the main test thread and the fake upstream thread. This contention exists in all tests that uses non-autonomous fake upstream, but more severe in tests with large payload because their clients have more IO events to handle while holding the mutex. This change modifies two things to mitigate the synchronization cost: Change large payload tests to use autonomous fake upstream, so that the synchronization between the main test thread and the fake upstream thread can be eliminated. Adjust the timeout of waitForWithDispatcherRun() to respect TSAN_TIMEOUT_FACTOR, so that the main test thread doesn't too aggressively acquire the mutex. Risk Level: low, test only Testing: existing tests Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Dan Zhang <danzh@google.com>

Fixes [envoyproxy#20977] Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

Signed-off-by: Ryan Northey <ryan@synca.io>

Add quiche_common_mem_slice_test and quiche_common_time_utils_test build targets of envoy_cc_test kind. Previously quiche_mem_slice_test.cc and quiche_time_utils_test.cc were part of quiche_common_platform_test, which is a envoy_cc_test_library (as opposed to a envoy_cc_test), therefore these tests were not actually ran. I verified that no other envoy_cc_test_library rules in this build file have source files matching ".*_test.cc" using the following command: bazel query 'attr("srcs", "_test.cc", \ attr(generator_function, envoy_cc_test_library, \ @com_github_google_quiche//...))' Signed-off-by: Bence Béky <bnc@google.com>

Signed-off-by: Biren Roy <birenroy@google.com>

…roxy#20831) Signed-off-by: Tianyu Xia <tyxia@google.com>

* lb fuzz test: Limit choice_count. Limit the choice_count to a reasonable number. Allowing any number has no added value. Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>

…rder (envoyproxy#20914) Test the case of only the listener filters order was updated, then the envoy will do a in-place update for this case. Signed-off-by: He Jie Xu <hejie.xu@intel.com>

RUNTIME_GUARD(envoy_reloadable_features_listener_reuse_port_default_enabled) Was already removed in envoyproxy#19977 but somehow it's back. Fixes envoyproxy#20987 Signed-off-by: Matt Klein <mklein@lyft.com>

…0997) Reset QuicheMemSliceImpl() in move assignment operator. Additional Description: minor tweak Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Bence Béky bnc@google.com

This gets us on rust 1.60 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

…nvoyproxy#20949) Signed-off-by: Raven Black <ravenblack@dropbox.com>

Signed-off-by: Ted Poole <tpoole@redhat.com>

1) Remove Dmitry 2) Add Kuat Signed-off-by: Matt Klein <mklein@lyft.com>

…ion (envoyproxy#20968) %UPSTREAM_PROTOCOL% get upstream protocol %UPSTREAM_PEER_SUBJECT% upstream TLS subject %UPSTREAM_PEER_ISSUER% upstream TLS certificate issuer %UPSTREAM_TLS_SESSION_ID% upstream TLS session ID %UPSTREAM_TLS_CIPHER% upstream TLS cipher %UPSTREAM_TLS_VERSION% upstream TLS version %UPSTREAM_PEER_CERT_V_START% upstream TLS cert validation start date %UPSTREAM_PEER_CERT_V_END% upstream TLS cert validation end/expiry date %UPSTREAM_PEER_CERT% upstream TLS certificate Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com> Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>

…roxy#22689) Commit Message: stream_idle_timer_ is armed to timeout the sending of the bufferred response payload in the quic stream send buffer after the end stream is buffered in the stream. But today this timer is armed even if the the encoding of the payload causes the stream to be closed, in which case the timer can never be cancelled till the stream destruction with ASSERT hit as below: [2022-08-12 22:23:38.843][12][critical][backtrace] [./source/server/backtrace.h:104] Caught Aborted, suspect faulting address 0x50e8d0000000c [2022-08-12 22:23:38.844][12][critical][backtrace] [./source/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers): [2022-08-12 22:23:38.844][12][critical][backtrace] [./source/server/backtrace.h:92] Envoy version: 0/1.24.0-dev/test/DEBUG/BoringSSL [2022-08-12 22:23:38.858][12][critical][backtrace] [./source/server/backtrace.h:96] #0: Envoy::SignalAction::sigHandler() [0x3480b28] [2022-08-12 22:23:38.858][12][critical][backtrace] [./source/server/backtrace.h:96] #1: __restore_rt [0x7f94b072c200] [2022-08-12 22:23:38.872][12][critical][backtrace] [./source/server/backtrace.h:96] #2: Envoy::Quic::EnvoyQuicStream::~EnvoyQuicStream() [0x2a2fe98] [2022-08-12 22:23:38.885][12][critical][backtrace] [./source/server/backtrace.h:96] #3: Envoy::Quic::EnvoyQuicServerStream::~EnvoyQuicServerStream() [0x2a78058] [2022-08-12 22:23:38.899][12][critical][backtrace] [./source/server/backtrace.h:96] #4: Envoy::Quic::EnvoyQuicServerStream::~EnvoyQuicServerStream() [0x2a77d30] [2022-08-12 22:23:38.912][12][critical][backtrace] [./source/server/backtrace.h:96] #5: Envoy::Quic::EnvoyQuicServerStream::~EnvoyQuicServerStream() [0x2a77d69] This change check stream close in this case, so that the idle timer will not be armed for closed streams. Risk Level: low Testing: new unit test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Dan Zhang <danzh@google.com>

…voyproxy#22856) `//test/integration:tcp_proxy_odcds_integration_test` was observed to fail as follows: ``` ==================== Test output for //test/integration:tcp_proxy_odcds_integration_test: [==========] Running 24 tests from 1 test suite. [----------] Global test environment set-up. [----------] 24 tests from IpVersionsClientType/TcpProxyOdcdsIntegrationTest [ RUN ] IpVersionsClientType/TcpProxyOdcdsIntegrationTest.SingleTcpClient/0 [2022-08-25 20:22:46.750][3969][critical][assert] [test/integration/fake_upstream.cc:832] assert failure: !dispatcher_->isThreadSafe(). [2022-08-25 20:22:46.752][3969][critical][backtrace] [./source/server/backtrace.h:104] Caught Aborted, suspect faulting address 0x6b00000f81 [2022-08-25 20:22:46.752][3969][critical][backtrace] [./source/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers): [2022-08-25 20:22:46.752][3969][critical][backtrace] [./source/server/backtrace.h:92] Envoy version: 0/1.24.0-dev/test/DEBUG/BoringSSL [2022-08-25 20:22:46.773][3969][critical][backtrace] [./source/server/backtrace.h:96] #0: Envoy::SignalAction::sigHandler() [0x4c46a78]->[0x2cf2a78] external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1267 [2022-08-25 20:22:46.773][3969][critical][backtrace] [./source/server/backtrace.h:96] #1: __restore_rt [0x7ffbdaa79420]->[0x7ffbd8b25420] ??:0 [2022-08-25 20:22:46.802][3969][critical][backtrace] [./source/server/backtrace.h:96] #2: Envoy::FakeUpstream::assertPendingConnectionsEmpty() [0x245bf0b]->[0x507f0b] ??:0 [2022-08-25 20:22:46.846][3969][critical][backtrace] [./source/server/backtrace.h:96] #3: Envoy::(anonymous namespace)::TcpProxyOdcdsIntegrationTest_SingleTcpClient_Test::TestBody() [0x1f596cb]->[0x56cb] ??:0 [2022-08-25 20:22:46.877][3969][critical][backtrace] [./source/server/backtrace.h:96] #4: testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x588b61b]->[0x393761b] ??:0 [2022-08-25 20:22:46.924][3969][critical][backtrace] [./source/server/backtrace.h:96] #5: testing::internal::HandleExceptionsInMethodIfSupported<>() [0x587c2bd]->[0x39282bd] ??:0 [2022-08-25 20:22:46.966][3969][critical][backtrace] [./source/server/backtrace.h:96] #6: testing::Test::Run() [0x5864ba3]->[0x3910ba3] /usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/stl_vector.h:0 [2022-08-25 20:22:47.003][3969][critical][backtrace] [./source/server/backtrace.h:96] #7: testing::TestInfo::Run() [0x586576a]->[0x391176a] external/com_google_absl/absl/container/internal/raw_hash_set.h:1259 [2022-08-25 20:22:47.037][3969][critical][backtrace] [./source/server/backtrace.h:96] #8: testing::TestSuite::Run() [0x5865fbb]->[0x3911fbb] /usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/stl_algo.h:1925 [2022-08-25 20:22:47.089][3969][critical][backtrace] [./source/server/backtrace.h:96] #9: testing::internal::UnitTestImpl::RunAllTests() [0x5874a28]->[0x3920a28] envoy/registry/registry.h:509 [2022-08-25 20:22:47.114][3969][critical][backtrace] [./source/server/backtrace.h:96] #10: testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x588ddbb]->[0x3939dbb] envoy/registry/registry.h:0 [2022-08-25 20:22:47.160][3969][critical][backtrace] [./source/server/backtrace.h:96] #11: testing::internal::HandleExceptionsInMethodIfSupported<>() [0x587e683]->[0x392a683] /usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/unique_ptr.h:154 [2022-08-25 20:22:47.191][3969][critical][backtrace] [./source/server/backtrace.h:96] #12: testing::UnitTest::Run() [0x5874568]->[0x3920568] envoy/registry/registry.h:508 [2022-08-25 20:22:47.237][3969][critical][backtrace] [./source/server/backtrace.h:96] #13: RUN_ALL_TESTS() [0x4878d51]->[0x2924d51] external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1203 [2022-08-25 20:22:47.284][3969][critical][backtrace] [./source/server/backtrace.h:96] #14: Envoy::TestRunner::RunTests() [0x48783b1]->[0x29243b1] external/com_google_googletest/googlemock/include/gmock/gmock-actions.h:485 [2022-08-25 20:22:47.316][3969][critical][backtrace] [./source/server/backtrace.h:96] #15: main [0x4874c3a]->[0x2920c3a] external/com_google_googletest/googlemock/include/gmock/gmock-spec-builders.h:1181 [2022-08-25 20:22:47.316][3969][critical][backtrace] [./source/server/backtrace.h:96] #16: __libc_start_main [0x7ffbda897083]->[0x7ffbd8943083] ??:0 ================================================================================ ``` This is due to the race described by envoyproxy#22855. Making sure the dispatcher thread is running before starting the test avoids this problem. Signed-off-by: Benjamin Peterson <benjamin@engflow.com>

This test sends a large number of metadata frames in order to trigger a disconnect. However, it was possible for the disconnect to happen and the connection to be torn down before all the metadata frames had been sent. If that happened, ASAN detected a UAF: ``` ==95==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700037e5a0 at pc 0x000004811f9e bp 0x7ffc903af990 sp 0x7ffc903af988 READ of size 8 at 0x60700037e5a0 thread T0 #0 0x4811f9d in Envoy::IntegrationCodecClient::sendMetadata(Envoy::Http::RequestEncoder&, Envoy::Http::MetadataMap) /proc/self/cwd/test/integration/http_integration.cc:168:3 #1 0x46ed711 in Envoy::Http2FloodMitigationTest_RequestMetadata_Test::TestBody() /proc/self/cwd/test/integration/http2_flood_integration_test.cc:1486:20 #2 0xd380e64 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2580:10 #3 0xd348dc2 in testing::Test::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2655:5 #4 0xd34a927 in testing::TestInfo::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2832:11 #5 0xd34ccc4 in testing::TestSuite::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2986:28 #6 0xd36f07a in testing::internal::UnitTestImpl::RunAllTests() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:5697:44 #7 0xd384e63 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/ gtest.cc:2580:10 #8 0xd36dd86 in testing::UnitTest::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:5280:10 #9 0xa0e53a4 in Envoy::TestRunner::RunTests(int, char**) /proc/self/cwd/external/com_google_googletest/googletest/include/gtest/gtest.h:2485:46 #10 0xa0e0af7 in main /proc/self/cwd/test/main.cc:34:10 #11 0x7f442ef69082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee) #12 0x45ed36d in _start (/mnt/ssd/cas/work/1/exec/bazel-out/k8-dbg/bin/test/integration/http2_flood_integration_test.runfiles/envoy/test/integration/http2_flood_integration_test+0x45ed36d) 0x60700037e5a0 is located 48 bytes inside of 80-byte region [0x60700037e570,0x60700037e5c0) freed by thread T0 here: #0 0x466f7d2 in free /local/mnt/workspace/bcain_clang_hu-bcain-lv_22036/final/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:52:3 #1 0x831dde8 in Envoy::Http::CodecClient::ActiveRequest::~ActiveRequest() /proc/self/cwd/./source/common/http/codec_client.h:220:10 #2 0x5aa33f9 in std::__1::unique_ptr<Envoy::Event::DeferredDeletable, std::__1::default_delete<Envoy::Event::DeferredDeletable> >::reset(Envoy::Event::DeferredDeletable*) /opt/llvm/bin/../include/c++/v1/__memory/unique_ptr.h:54:5 #3 0xa3218e8 in Envoy::Event::DispatcherImpl::clearDeferredDeleteList() /proc/self/cwd/source/common/event/dispatcher_impl.cc:142:21 #4 0xa3348df in void std::__1::__invoke_void_return_wrapper<void, true>::__call<Envoy::Event::DispatcherImpl::DispatcherImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Envoy::Thread::ThreadFactory&, Envoy::TimeSource& , Envoy::Random::RandomGenerator&, Envoy::Filesystem::Instance&, Envoy::Event::TimeSystem&, std::__1::function<std::__1::unique_ptr<Envoy::Event::ScaledRangeTimerManager, std::__1::default_delete<Envoy::Event::ScaledRangeTimerManager> > (Envoy::Event::Dispatcher&)> const& , std::__1::shared_ptr<Envoy::Buffer::WatermarkFactory> const&)::$_2&>(Envoy::Event::DispatcherImpl::DispatcherImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Envoy::Thread::ThreadFactory&, Envoy::TimeSource&, Envoy::Rand om::RandomGenerator&, Envoy::Filesystem::Instance&, Envoy::Event::TimeSystem&, std::__1::function<std::__1::unique_ptr<Envoy::Event::ScaledRangeTimerManager, std::__1::default_delete<Envoy::Event::ScaledRangeTimerManager> > (Envoy::Event::Dispatcher&)> const&, std::__1::s hared_ptr<Envoy::Buffer::WatermarkFactory> const&)::$_2&) /proc/self/cwd/source/common/event/dispatcher_impl.cc:79:30 #5 0xa334603 in std::__1::__function::__func<Envoy::Event::DispatcherImpl::DispatcherImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Envoy::Thread::ThreadFactory&, Envoy::TimeSource&, Envoy::Random::RandomGenerator&, Envoy::Filesystem::Instance&, Envoy::Event::TimeSystem&, std::__1::function<std::__1::unique_ptr<Envoy::Event::ScaledRangeTimerManager, std::__1::default_delete<Envoy::Event::ScaledRangeTimerManager> > (Envoy::Event::Dispatcher&)> const&, std::__1::shared_ptr<Envoy::Buffe r::WatermarkFactory> const&)::$_2, std::__1::allocator<Envoy::Event::DispatcherImpl::DispatcherImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, Envoy::Thread::ThreadFactory&, Envoy::TimeSource&, Envoy::Random::RandomGenera tor&, Envoy::Filesystem::Instance&, Envoy::Event::TimeSystem&, std::__1::function<std::__1::unique_ptr<Envoy::Event::ScaledRangeTimerManager, std::__1::default_delete<Envoy::Event::ScaledRangeTimerManager> > (Envoy::Event::Dispatcher&)> const&, std::__1::shared_ptr<Envoy: :Buffer::WatermarkFactory> const&)::$_2>, void ()>::operator()() /opt/llvm/bin/../include/c++/v1/__functional/function.h:180:16 #6 0x4897039 in std::__1::__function::__value_func<void ()>::operator()() const /opt/llvm/bin/../include/c++/v1/__functional/function.h:507:16 #7 0xa8e6aa4 in Envoy::Event::SchedulableCallbackImpl::SchedulableCallbackImpl(Envoy::CSmartPtr<event_base, &(event_base_free)>&, std::__1::function<void ()>)::$_0::__invoke(int, short, void*) /opt/llvm/bin/../include/c++/v1/__functional/function.h:1184:12 #8 0xb557c5e in event_process_active_single_queue /mnt/ssd/cas/work/2/exec/external/com_github_libevent_libevent/event.c:1713:4 #9 0xb539252 in event_process_active /mnt/ssd/cas/work/2/exec/external/com_github_libevent_libevent/event.c #10 0xb539252 in event_base_loop /mnt/ssd/cas/work/2/exec/external/com_github_libevent_libevent/event.c:2047:12 #11 0xa8e1e3c in Envoy::Event::LibeventScheduler::run(Envoy::Event::Dispatcher::RunType) /proc/self/cwd/source/common/event/libevent_scheduler.cc:60:3 #12 0xa32bd94 in Envoy::Event::DispatcherImpl::run(Envoy::Event::Dispatcher::RunType) /proc/self/cwd/source/common/event/dispatcher_impl.cc:299:19 #13 0x480faad in Envoy::IntegrationCodecClient::flushWrite() /proc/self/cwd/test/integration/http_integration.cc:100:29 #14 0x4811e94 in Envoy::IntegrationCodecClient::sendMetadata(Envoy::Http::RequestEncoder&, Envoy::Http::MetadataMap) /proc/self/cwd/test/integration/http_integration.cc:169:3 #15 0x46ed711 in Envoy::Http2FloodMitigationTest_RequestMetadata_Test::TestBody() /proc/self/cwd/test/integration/http2_flood_integration_test.cc:1486:20 #16 0xd380e64 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2580:10 #17 0xd348dc2 in testing::Test::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2655:5 #18 0xd34a927 in testing::TestInfo::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2832:11 #19 0xd34ccc4 in testing::TestSuite::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2986:28 #20 0xd36f07a in testing::internal::UnitTestImpl::RunAllTests() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:5697:44 #21 0xd384e63 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2580:10 #22 0xd36dd86 in testing::UnitTest::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:5280:10 #23 0xa0e53a4 in Envoy::TestRunner::RunTests(int, char**) /proc/self/cwd/external/com_google_googletest/googletest/include/gtest/gtest.h:2485:46 #24 0xa0e0af7 in main /proc/self/cwd/test/main.cc:34:10 #25 0x7f442ef69082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee) ``` To fix that, write all metadata frames at once. Signed-off-by: Benjamin Peterson <benjamin@engflow.com>

When building the jni dylib for android, we previously stripped all debug info to decrease the artifact size. With this change we now produce the same stripped binary as before, but before stripping it we create a dump of the debug info suitable for crash reporting. This is made overly difficult for a few reasons: 1. Bazel doesn't support fission for Android bazelbuild/bazel#14765 2. Extra outputs from rules are not propagated up the dependency tree, so just building `android_dist` at the top level, isn't enough to get the extra outputs built as well 3. Building the library manually alongside the android artifact on the command line results in 2 separate builds, one for android as a transitive dependency of `android_dist` and one for the host platform This change avoids #1 fission for now, but the same approach could be used once that change makes its way to a bazel release. This change fixes #2 by using a separate output group that can be depended on by the genrule that writes to dist while avoiding #3 because the custom rule producing these uses the android transition. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>

Commit Message: the probing socket is released when port migration fails. If this happens in response to an incoming packet during an I/O event, the follow socket read could cause use-after-free. [2024-01-08 16:30:53.386][12][critical][backtrace] [./source/server/backtrace.h:104] Caught Segmentation fault, suspect faulting address 0x0 [2024-01-08 16:30:53.387][12][critical][backtrace] [./source/server/backtrace.h:91] Backtrace (use tools/stack_decode.py to get line numbers): [2024-01-08 16:30:53.387][12][critical][backtrace] [./source/server/backtrace.h:92] Envoy version: 0/1.29.0-dev/test/DEBUG/BoringSSL [2024-01-08 16:30:53.413][12][critical][backtrace] [./source/server/backtrace.h:96] #0: Envoy::SignalAction::sigHandler() [0x55bb876d499e] [2024-01-08 16:30:53.413][12][critical][backtrace] [./source/server/backtrace.h:98] #1: [0x7f55fbf92510] [2024-01-08 16:30:53.440][12][critical][backtrace] [./source/server/backtrace.h:96] #2: Envoy::Network::Utility::readPacketsFromSocket() [0x55bb875de0ef] [2024-01-08 16:30:53.466][12][critical][backtrace] [./source/server/backtrace.h:96] #3: Envoy::Quic::EnvoyQuicClientConnection::onFileEvent() [0x55bb8663e1eb] [2024-01-08 16:30:53.492][12][critical][backtrace] [./source/server/backtrace.h:96] #4: Envoy::Quic::EnvoyQuicClientConnection::setUpConnectionSocket()::$_0::operator()() [0x55bb8663f192] [2024-01-08 16:30:53.518][12][critical][backtrace] [./source/server/backtrace.h:96] #5: std::__invoke_impl<>() [0x55bb8663f151] [2024-01-08 16:30:53.544][12][critical][backtrace] [./source/server/backtrace.h:96] #6: std::__invoke_r<>() [0x55bb8663f0e2] [2024-01-08 16:30:53.569][12][critical][backtrace] [./source/server/backtrace.h:96] #7: std::_Function_handler<>::_M_invoke() [0x55bb8663efc2] [2024-01-08 16:30:53.595][12][critical][backtrace] [./source/server/backtrace.h:96] #8: std::function<>::operator()() [0x55bb85cb8f44] [2024-01-08 16:30:53.621][12][critical][backtrace] [./source/server/backtrace.h:96] #9: Envoy::Event::DispatcherImpl::createFileEvent()::$_5::operator()() [0x55bb8722560f] [2024-01-08 16:30:53.648][12][critical][backtrace] [./source/server/backtrace.h:96] #10: std::__invoke_impl<>() [0x55bb872255c1] [2024-01-08 16:30:53.674][12][critical][backtrace] [./source/server/backtrace.h:96] #11: std::__invoke_r<>() [0x55bb87225562] [2024-01-08 16:30:53.700][12][critical][backtrace] [./source/server/backtrace.h:96] #12: std::_Function_handler<>::_M_invoke() [0x55bb872253e2] [2024-01-08 16:30:53.700][12][critical][backtrace] [./source/server/backtrace.h:96] #13: std::function<>::operator()() [0x55bb85cb8f44] [2024-01-08 16:30:53.726][12][critical][backtrace] [./source/server/backtrace.h:96] #14: Envoy::Event::FileEventImpl::mergeInjectedEventsAndRunCb() [0x55bb872358ec] [2024-01-08 16:30:53.752][12][critical][backtrace] [./source/server/backtrace.h:96] #15: Envoy::Event::FileEventImpl::assignEvents()::$_1::operator()() [0x55bb87235ed1] [2024-01-08 16:30:53.778][12][critical][backtrace] [./source/server/backtrace.h:96] #16: Envoy::Event::FileEventImpl::assignEvents()::$_1::__invoke() [0x55bb87235949] [2024-01-08 16:30:53.804][12][critical][backtrace] [./source/server/backtrace.h:96] #17: event_persist_closure [0x55bb87fab72b] [2024-01-08 16:30:53.830][12][critical][backtrace] [./source/server/backtrace.h:96] #18: event_process_active_single_queue [0x55bb87faada2] [2024-01-08 16:30:53.856][12][critical][backtrace] [./source/server/backtrace.h:96] #19: event_process_active [0x55bb87fa56c8] [2024-01-08 16:30:53.882][12][critical][backtrace] [./source/server/backtrace.h:96] #20: event_base_loop [0x55bb87fa45cc] [2024-01-08 16:30:53.908][12][critical][backtrace] [./source/server/backtrace.h:96] #21: Envoy::Event::LibeventScheduler::run() [0x55bb8760a59f] Risk Level: low Testing: new unit test Docs Changes: N/A Release Notes: Yes Platform Specific Features: N/A Signed-off-by: Dan Zhang <danzh@google.com> Co-authored-by: Dan Zhang <danzh@google.com>

wbpcode and others added 30 commits March 28, 2022 09:52

router: inject tracing context in the upstream request (envoyproxy#20503

57a69f3

) Signed-off-by: wbpcode <wbphub@live.com>

cares: fix bad cleanup of parallel All query during destroy (envoypro…

419e237

…xy#20551) The code was not accounting for parallel queries in this path. Also add more assertions to make similar issues easier to understand in the future. Signed-off-by: Matt Klein <mklein@lyft.com>

Abstraction ECDS config discovery header file to make it extendable (e…

b5d7c59

…nvoyproxy#20445) * Further abstraction ECDS config discovery header file to make it extendable to other filters. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>

http: respecting content encoding on local replies (envoyproxy#20460)

80c7e5b

Risk Level: Low Testing: integration test Docs Changes: n/a Release Notes: inline Runtime guard: yes Fixes envoyproxy#20267 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

chore: remove useless comment for tls key log (envoyproxy#20550)

b77651d

Signed-off-by: rainingmaster <jinhua.tan@bytedance.com>

wasm: migrate to Emscripten's native Bazel rules. (envoyproxy#19579)

6d7f5ab

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Update OutOfOrder test to use new addDefaultHeaders interface (envoyp…

575cab4

…roxy#20557) Signed-off-by: Justin Mazzola Paluska <justinmp@google.com>

udp_proxy: support file access logging (envoyproxy#20103)

4dc78de

Signed-off-by: giantcroc <changran.wang@intel.com>

build: Update to bazel 5.1.0

fd92486

https://blog.bazel.build/2022/03/24/bazel-5.1.html Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

ci: remove unused variable (NFC)

554a6ec

The last consumer of this was removed in the linked commit Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

listener: remove the peek from the listener filters (envoyproxy#17395)

93b0a4e

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

access_log: support new log formatter to get value from environment v…

2992c4c

…ariable (envoyproxy#20386) Signed-off-by: wbpcode <wbphub@live.com>

contrib-sipproxy: Fix TRA Ut (envoyproxy#20443)

08c2e5a

Signed-off-by: Felix Du <durd07@gmail.com>

listener: fix tls inspector's maxReadBytes() return type (envoyproxy#…

74d50f9

…20579) Signed-off-by: He Jie Xu <hejie.xu@intel.com>

test: creating a test listener filter and moving the xds test over to…

2757eb9

… it (envoyproxy#20571) Part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

builld: tweaking visibility rules (envoyproxy#20552)

0ab9440

Risk Level: n/a (visibility only) part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

docs: Clarify that RegexMatcher uses a full regex match (envoyproxy#2…

4aee67a

…0570) Signed-off-by: Greg Greenway <ggreenway@apple.com>

test: moving the tls inspector test to the extension directory (envoy…

f9d936e

…proxy#20588) Part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

tools: disallowing visibility changes by default (envoyproxy#20590)

3f8c00c

Testing: ran against envoyproxy#20552 :-) Leaving those BUILD files in as example exemptions. Fixes envoyproxy#20589 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

add some more note about ipv6 support of docker networking in the sta…

9113148

…rt docs (envoyproxy#20582) Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

soulxu and others added 23 commits April 26, 2022 08:19

build: make factory_base_lib visibility public (envoyproxy#20994)

fe30283

This allows out-or-repo filters to use it. Signed-off-by: Greg Greenway <ggreenway@apple.com>

remove fix-added-trailers (envoyproxy#21001)

cad3fe7

fixes envoyproxy#20979 Signed-off-by: giantcroc <changran.wang@intel.com>

fuzz: Conn manager fuzz test improve (envoyproxy#20902)

6d5fe3b

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>

route: custom cluster specifier plugin support (envoyproxy#20151)

07e414c

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

server properties: tracking concurrent streams (not used yet) (envoyp…

f6f11e8

…roxy#20834) Risk Level: low Testing: new unit testing Docs Changes: n/a Release Notes: n/a Part of envoyproxy#20696 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

runtime: removing correct_scheme_and_xfp (envoyproxy#20982)

b425816

Fixes [envoyproxy#20977] Signed-off-by: Alyssa Wilk <alyssar@chromium.org>

docs: Add missing (1.19.3) version_history (envoyproxy#21012)

9f0a0aa

Signed-off-by: Ryan Northey <ryan@synca.io>

Adds test targets for QUICHE HTTP/2 libraries (envoyproxy#20999)

96f052a

Signed-off-by: Biren Roy <birenroy@google.com>

GCP Authentication Filter: Update the API proto for audience. (envoyp…

f0ba408

…roxy#20831) Signed-off-by: Tianyu Xia <tyxia@google.com>

lb fuzz test: Limit choice_count. (envoyproxy#20922)

51a336e

* lb fuzz test: Limit choice_count. Limit the choice_count to a reasonable number. Allowing any number has no added value. Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>

listener: add integration test for in-place update listener filters o…

9cb61ae

…rder (envoyproxy#20914) Test the case of only the listener filters order was updated, then the envoy will do a in-place update for this case. Signed-off-by: He Jie Xu <hejie.xu@intel.com>

runtime: remove stale guard (envoyproxy#21020)

53a925b

RUNTIME_GUARD(envoy_reloadable_features_listener_reuse_port_default_enabled) Was already removed in envoyproxy#19977 but somehow it's back. Fixes envoyproxy#20987 Signed-off-by: Matt Klein <mklein@lyft.com>

bazel: update rules_rust

1a635a7

This gets us on rust 1.60 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Add FileSystemBuffer::Fragment class to support file_system_buffer (e…

e4e6488

…nvoyproxy#20949) Signed-off-by: Raven Black <ravenblack@dropbox.com>

Updated zlib to version 1.2.12 (envoyproxy#21014)

5da6d40

Signed-off-by: Ted Poole <tpoole@redhat.com>

owners: maintainer updates (envoyproxy#21023)

55859a7

1) Remove Dmitry 2) Add Kuat Signed-off-by: Matt Klein <mklein@lyft.com>

Merge branch 'main' into multiple_addresses_for_listener_4_27

ba23375

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

Fix the main merge

9fcdea7

Signed-off-by: He Jie Xu <hejie.xu@intel.com>

soulxu pushed a commit that referenced this pull request May 16, 2022

cryptomb: add support for PKCS #1 1.5 RSA padding. (envoyproxy#21286)

9476543

Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com>

soulxu closed this Apr 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple addresses for listener 4 27#1

Multiple addresses for listener 4 27#1
soulxu wants to merge 2870 commits intomainfrom
multiple_addresses_for_listener_4_27

soulxu commented May 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

soulxu commented May 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants