docs: Clarify that RegexMatcher uses a full regex match#20570
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Mar 30, 2022
Merged
docs: Clarify that RegexMatcher uses a full regex match#20570ggreenway merged 2 commits intoenvoyproxy:mainfrom
ggreenway merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
ggreenway
commented
Mar 29, 2022
| } | ||
|
|
||
| // The regex match string. The string must be supported by the configured engine. | ||
| // The regex match string. The string must be supported by the configured engine. The regex should |
Member
Author
There was a problem hiding this comment.
I'm not thrilled with this wording. Anyone have a better way to phrase it?
Member
There was a problem hiding this comment.
The full match string supported by the specified regex engine?
Contributor
There was a problem hiding this comment.
How about "The regex is matched against the full string, not as a partial match."
Member
Author
|
For reference, the matching is done as: |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Contributor
|
/lgtm api |
adisuissa
approved these changes
Mar 30, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Let's just wait for green CI.
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…0570) Signed-off-by: Greg Greenway <ggreenway@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Greenway ggreenway@apple.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]