listener: add integration test for in-place update listener filters order#20914
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Apr 26, 2022
Merged
listener: add integration test for in-place update listener filters order#20914ggreenway merged 2 commits intoenvoyproxy:mainfrom
ggreenway merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
lambdai
suggested changes
Apr 22, 2022
Contributor
lambdai
left a comment
lambdai
left a comment
There was a problem hiding this comment.
Thank you so much!
Generally LGTM modulo some nits
ggreenway
approved these changes
Apr 26, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…rder (envoyproxy#20914) Test the case of only the listener filters order was updated, then the envoy will do a in-place update for this case. Signed-off-by: He Jie Xu <hejie.xu@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: He Jie Xu hejie.xu@intel.com
Commit Message: listener: add integration test for in-place update listener filters order
Additional Description:
Test the case of only the listener filters order was updated, then the envoy will do a in-place update for this case.
Risk Level: low
Testing: integration test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Part of Fixes #20100