contrib-sipproxy: Fix TRA Ut#20443
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Mar 30, 2022
Merged
Conversation
Signed-off-by: Felix Du <durd07@gmail.com>
Member
|
@phlax now we do not run contrib tests in CI, if codes only cover changes under contrib, how about only test format and skip unit tests since all unit tests are not changed. |
Member
|
not sure if i follow entirely @daixiang0 - either way i will leave it to @ggreenway as i believe he will have a better understanding of what is being changed and any necessity or otherwise |
Member
Author
|
@ggreenway Could you please help to review and merge it? |
Member
Author
Contributor
|
@ggreenway can you PTAL? |
ggreenway
approved these changes
Mar 30, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Felix Du <durd07@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Du durd07@gmail.com
Commit Message: Fix TRA Ut
Additional Description:
Risk Level: Low
Testing: Ut
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]