test: creating a test listener filter and moving the xds test over to it#20571
test: creating a test listener filter and moving the xds test over to it#20571alyssawilk merged 3 commits intoenvoyproxy:mainfrom
Conversation
alyssawilk
changed the title
it. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
test_listener_filter
branch
from
4bdee74 to
aaef467
Compare
| } | ||
|
|
||
| ProtobufTypes::MessagePtr createEmptyConfigProto() override { | ||
| return ProtobufTypes::MessagePtr{new Envoy::ProtobufWkt::Struct()}; |
There was a problem hiding this comment.
I mean it's not needed here, so would it make sense to add it as a follow up over in one of those PRs?
There was a problem hiding this comment.
oh whoops, I was looking at the second and not the first. :-/
alyssawilk
force-pushed
the
test_listener_filter
branch
from
5594118 to
392c683
Compare
| alpn_.clear(); | ||
| return Network::FilterStatus::Continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh thanks for the heads up - github hadn't picked up what would have broken CI :-)
| std::string name() const override { return "envoy.filters.listener.test"; } | ||
| }; | ||
|
|
||
| absl::Mutex TestListenerFilter::alpn_lock_; |
There was a problem hiding this comment.
Another way is to set the alpn as a parameter for this filter config, then we can get per-instance alpn value. But yes, it needs more code probably.
There was a problem hiding this comment.
I think that doesn't work as we want one filter which returns different alpn values for different connections. But anyway the goal is to just have those tests pass without a filter some folks don't want to include so I think simple (with crummy locks) is fine :-)
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
… it (envoyproxy#20571) Part of envoyproxy#9953 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
4 participants
Part of #9953