Abstraction ECDS config discovery header file to make it extendable#20445
Merged
adisuissa merged 7 commits intoenvoyproxy:mainfrom Mar 28, 2022
Merged
Abstraction ECDS config discovery header file to make it extendable#20445adisuissa merged 7 commits intoenvoyproxy:mainfrom
adisuissa merged 7 commits intoenvoyproxy:mainfrom
Conversation
…ndable to other filters. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
changed the title
Contributor
Author
|
/assign @adisuissa @yanavlasov |
Contributor
Author
|
/assign @kyessenov |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
adisuissa
requested changes
Mar 22, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks! Left a few comments.
I think this refactor makes sense.
@kyessenov WDYT?
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
kyessenov
reviewed
Mar 22, 2022
Contributor
|
Makes sense to me. Left a comment to confirm that we don't have redundant code. |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
adisuissa
reviewed
Mar 24, 2022
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM other than the nit.
/assign-from @envoyproxy/senior-maintainers
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Contributor
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @yanavlasov |
adisuissa
approved these changes
Mar 25, 2022
Contributor
Author
|
Contributor
|
Thanks, my comment was addressed. |
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…nvoyproxy#20445) * Further abstraction ECDS config discovery header file to make it extendable to other filters. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description:
Further abstraction ECDS config discovery header file to make it extendable for other filters like lisenter ECDS filter.
This is the follow up work to support listener filter ECDS as in issue: #20049.
The reason for this change is that prior to #20445, the two methods in class DynamicFilterConfigProviderImpl is tied into HTTP listener only:
validateMessage()
instantiateFilterFactory().
Thus #20445 is to abstract them out thus the logic can be implemented in filter type specific class.
Build:
passed
Testing:
passed
Release Notes:
N/A
Issues: ecds: add support for listener filters #20049
Signed-off-by: Yanjun Xiang yanjunxiang@google.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]