quiche: add mem_slice_test and time_utils_test targets#21013
Merged
RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom Apr 26, 2022
bencebeky:mem-slice-test
Merged
quiche: add mem_slice_test and time_utils_test targets#21013RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom bencebeky:mem-slice-test
RyanTheOptimist merged 1 commit intoenvoyproxy:mainfrom
bencebeky:mem-slice-test
Conversation
Add quiche_common_mem_slice_test and quiche_common_time_utils_test build
targets of envoy_cc_test kind. Previously quiche_mem_slice_test.cc and
quiche_time_utils_test.cc were part of quiche_common_platform_test,
which is a envoy_cc_test_library (as opposed to a envoy_cc_test),
therefore these tests were not actually ran.
I verified that no other envoy_cc_test_library rules in this
build file have source files matching ".*_test.cc" using the following
command:
bazel query 'attr("srcs", "_test.cc", \
attr(generator_function, envoy_cc_test_library, \
@com_github_google_quiche//...))'
Signed-off-by: Bence Béky <bnc@google.com>
Contributor
Author
|
/assign @danzh2010 Dan: PTAL. I noticed this bug when I tried to run |
danzh2010
approved these changes
Apr 26, 2022
Contributor
danzh2010
left a comment
danzh2010
left a comment
There was a problem hiding this comment.
LGTM over all. A nit about using "quiche: add mem_slice_test and time_utils_test targets" as the title.
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
bencebeky
changed the title
Contributor
Author
|
/assign @RyanTheOptimist |
RyanTheOptimist
approved these changes
Apr 26, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Add quiche_common_mem_slice_test and quiche_common_time_utils_test build
targets of envoy_cc_test kind. Previously quiche_mem_slice_test.cc and
quiche_time_utils_test.cc were part of quiche_common_platform_test,
which is a envoy_cc_test_library (as opposed to a envoy_cc_test),
therefore these tests were not actually ran.
I verified that no other envoy_cc_test_library rules in this
build file have source files matching ".*_test.cc" using the following
command:
bazel query 'attr("srcs", "_test.cc", \
attr(generator_function, envoy_cc_test_library, \
@com_github_google_quiche//...))'
Signed-off-by: Bence Béky <bnc@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add quiche_common_mem_slice_test and quiche_common_time_utils_test build
targets of envoy_cc_test kind. Previously quiche_mem_slice_test.cc and
quiche_time_utils_test.cc were part of quiche_common_platform_test,
which is a envoy_cc_test_library (as opposed to a envoy_cc_test),
therefore these tests were not actually ran.
I verified that no other envoy_cc_test_library rules in this
build file have source files matching ".*_test.cc" using the following
command:
bazel query 'attr("srcs", "_test.cc",
attr(generator_function, envoy_cc_test_library,
@com_github_google_quiche//...))'
Signed-off-by: Bence Béky bnc@google.com
Commit Message: Add mem_slice_test and time_utils_test targets.
Additional Description:
Risk Level: low (test-only)
Testing: n/a (test-only)
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]