test: switching one more wait to not infinitely time out for failures#20488
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Mar 30, 2022
Merged
test: switching one more wait to not infinitely time out for failures#20488alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
alyssawilk
force-pushed
the
disallow_timeout
branch
5 times, most recently
from
462c353 to
1a5519a
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
disallow_timeout
branch
from
1a5519a to
cfaece7
Compare
alyssawilk
requested review from
ggreenway,
htuch,
lizan and
zuercher
as code owners
KBaichoo
approved these changes
Mar 30, 2022
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning these up.
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…envoyproxy#20488) Follow up on envoyproxy#20468 to future-proof against slow tests, by adding a default timeout to the raw connection driver This caught a whole bunch of tests which were waiting 15s for delay close. Risk Level: n/a (test only) Testing: CI Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #20468 to future-proof against slow tests, by adding a default timeout to the raw connection driver
This caught a whole bunch of tests which were waiting 15s for delay close.
Risk Level: n/a (test only)
Testing: CI