chore: remove useless comment for tls key log#20550
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom Mar 29, 2022
Merged
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: rainingmaster <jinhua.tan@bytedance.com>
rainingmaster
force-pushed
the
chore/keylog_comment
branch
from
ba881b9 to
f0d6195
Compare
ggreenway
approved these changes
Mar 28, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
Signed-off-by: rainingmaster <jinhua.tan@bytedance.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: remove useless comment for tls key log
Additional Description: This comment is useless now. It should be useful during this commit, and should be remove after this discussion.
Risk Level: Low
Testing: Testing with neither
local_address_rangenorremote_address_rangeDocs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A