Skip to content

access_log: Added new command operators to retrieve upstream information#20968

Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
surki:access_log_tls_upstream
Apr 26, 2022
Merged

access_log: Added new command operators to retrieve upstream information#20968
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
surki:access_log_tls_upstream

Conversation

@surki
Copy link
Copy Markdown
Contributor

@surki surki commented Apr 25, 2022

Commit Message: access_log: Added new command operators to retrieve upstream connection information
Additional Description: Need to add information upstream (protocol and TLS info) information in access log (using it in the context of "dynamic forward proxy" but is also usable generally). So added following command operators

%UPSTREAM_PROTOCOL%           get upstream protocol
%UPSTREAM_PEER_SUBJECT%       upstream TLS subject
%UPSTREAM_PEER_ISSUER%        upstream TLS certificate issuer
%UPSTREAM_TLS_SESSION_ID%     upstream TLS session ID
%UPSTREAM_TLS_CIPHER%         upstream TLS cipher
%UPSTREAM_TLS_VERSION%        upstream TLS version
%UPSTREAM_PEER_CERT_V_START%  upstream TLS cert validation start date
%UPSTREAM_PEER_CERT_V_END%    upstream TLS cert validation end/expiry date
%UPSTREAM_PEER_CERT%          upstream TLS certificate

Risk Level: Low
Testing: unit testing and manual testing
Docs Changes: Added
Release Notes: Added
Platform Specific Features:
Fixes #20939

…on information

%UPSTREAM_PROTOCOL%           get upstream protocol
%UPSTREAM_PEER_SUBJECT%       upstream TLS subject
%UPSTREAM_PEER_ISSUER%        upstream TLS certificate issuer
%UPSTREAM_TLS_SESSION_ID%     upstream TLS session ID
%UPSTREAM_TLS_CIPHER%         upstream TLS cipher
%UPSTREAM_TLS_VERSION%        upstream TLS version
%UPSTREAM_PEER_CERT_V_START%  upstream TLS cert validation start date
%UPSTREAM_PEER_CERT_V_END%    upstream TLS cert validation end/expiry date
%UPSTREAM_PEER_CERT%          upstream TLS certificate

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>
@surki surki force-pushed the access_log_tls_upstream branch from 51b11f0 to 8866e59 Compare April 25, 2022 10:44
Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>
Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@mattklein123 mattklein123 merged commit 3883a94 into envoyproxy:main Apr 26, 2022
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
…ion (envoyproxy#20968)

%UPSTREAM_PROTOCOL%           get upstream protocol
%UPSTREAM_PEER_SUBJECT%       upstream TLS subject
%UPSTREAM_PEER_ISSUER%        upstream TLS certificate issuer
%UPSTREAM_TLS_SESSION_ID%     upstream TLS session ID
%UPSTREAM_TLS_CIPHER%         upstream TLS cipher
%UPSTREAM_TLS_VERSION%        upstream TLS version
%UPSTREAM_PEER_CERT_V_START%  upstream TLS cert validation start date
%UPSTREAM_PEER_CERT_V_END%    upstream TLS cert validation end/expiry date
%UPSTREAM_PEER_CERT%          upstream TLS certificate

Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>
Signed-off-by: Suresh Kumar <sureshkumar.pp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

access_log: upstream tls details

3 participants