cares: fix bad cleanup of parallel All query during destroy#20551
Merged
yanavlasov merged 1 commit intomainfrom Mar 28, 2022
Merged
cares: fix bad cleanup of parallel All query during destroy#20551yanavlasov merged 1 commit intomainfrom
yanavlasov merged 1 commit intomainfrom
Conversation
The code was not accounting for parallel queries in this path. Also add more assertions to make similar issues easier to understand in the future. Signed-off-by: Matt Klein <mklein@lyft.com>
snowp
approved these changes
Mar 28, 2022
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Change makes sense to me, thanks!
yanavlasov
approved these changes
Mar 28, 2022
Augustyniak
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Mar 28, 2022
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Picking up a crash fix for when ALL DNS mode is enabled on Android (as a result of Happy Eyeballs feature being enabled) envoyproxy/envoy#20551
mattklein123
added a commit
that referenced
this pull request
Mar 28, 2022
The code was not accounting for parallel queries in this path. Also add more assertions to make similar issues easier to understand in the future. Signed-off-by: Matt Klein <mklein@lyft.com>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…xy#20551) The code was not accounting for parallel queries in this path. Also add more assertions to make similar issues easier to understand in the future. Signed-off-by: Matt Klein <mklein@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was not accounting for parallel queries in this path. Also
add more assertions to make similar issues easier to understand in
the future.
Risk Level: Medium (code is very tricky, hard to understand all implications of the change, and per TODO test coverage is missing on some clearly critical paths).
Testing: New failing test prior to fix
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A