Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
we had a connect test which was doing sendRawHttpAndWaitForResponse, which generally waits for a completely framed response, and the while point of CONNECT proxying is the "body" isn't ever complete. Setting disconnect_after_headers_complete = true means the test finishes up after the headers are sent rather than waiting for a body which will never arrive. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…envoyproxy#20488) Follow up on envoyproxy#20468 to future-proof against slow tests, by adding a default timeout to the raw connection driver This caught a whole bunch of tests which were waiting 15s for delay close. Risk Level: n/a (test only) Testing: CI Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we had a connect test which was doing sendRawHttpAndWaitForResponse, which generally waits for a completely framed response, and the while point of CONNECT proxying is the "body" isn't ever complete. Setting disconnect_after_headers_complete = true means the test finishes up after the headers are sent rather than waiting for a body which will never arrive.