Skip to content

GCP Authentication Filter: Update the API proto for audience.#20831

Merged
yanavlasov merged 3 commits intoenvoyproxy:mainfrom
tyxia:audience
Apr 26, 2022
Merged

GCP Authentication Filter: Update the API proto for audience.#20831
yanavlasov merged 3 commits intoenvoyproxy:mainfrom
tyxia:audience

Conversation

@tyxia
Copy link
Copy Markdown
Member

@tyxia tyxia commented Apr 14, 2022

map is not needed for the audience url (and no lookup is performed anyway because the key is currently a fixed string..). The audience URL is provided to the filer extension through cluster's typed_filter_metadata . And the cluster selection is based on the information in each route : context_.clusterManager().getThreadLocalCluster(route->routeEntry()->clusterName());.

So the correctness of type_filter_metadata is already guaranteed by the lookup at cluster level (i.e. getThreadLocalCluster()) based on destination cluster information in the route and no lookup of map struct is needed here.

Signed-off-by: Tianyu Xia tyxia@google.com

Signed-off-by: Tianyu Xia <tyxia@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20831 was opened by tyxia.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #20831 was opened by tyxia.

see: more, trace.

Signed-off-by: Tianyu Xia <tyxia@google.com>
@tyxia
Copy link
Copy Markdown
Member Author

tyxia commented Apr 14, 2022

/assign @yanavlasov

PTAL as well. Thanks!

@repokitteh-read-only
Copy link
Copy Markdown

🙀 Error while processing event:

evaluation error
error: function _rk_error error: path contains forbidden characters:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:135: in _main
  bootstrap:62: in _call
  bootstrap:15: in _call1
  github.com/repokitteh/modules/assign.star:18: in _assign
  github:395: in issue_check_assignee
  github:131: in call
Error: function _rk_error error: path contains forbidden characters
🐱

Caused by: a #20831 (comment) was created by @tyxia.

see: more, trace.

@tyxia tyxia marked this pull request as ready for review April 14, 2022 20:31
@tyxia tyxia requested a review from yanavlasov as a code owner April 14, 2022 20:31
@tyxia
Copy link
Copy Markdown
Member Author

tyxia commented Apr 14, 2022

/assign @yanavlasov

PTAL. Thanks!

Copy link
Copy Markdown
Contributor

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@alyssawilk
Copy link
Copy Markdown
Contributor

@yanavlasov ping!

@yanavlasov yanavlasov merged commit f0ba408 into envoyproxy:main Apr 26, 2022
@tyxia tyxia deleted the audience branch April 27, 2022 14:52
ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants