GCP Authentication Filter: Update the API proto for audience.#20831
Merged
yanavlasov merged 3 commits intoenvoyproxy:mainfrom Apr 26, 2022
Merged
GCP Authentication Filter: Update the API proto for audience.#20831yanavlasov merged 3 commits intoenvoyproxy:mainfrom
yanavlasov merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Tianyu Xia <tyxia@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Tianyu Xia <tyxia@google.com>
Member
Author
|
/assign @yanavlasov PTAL as well. Thanks! |
|
🙀 Error while processing event: |
Member
Author
|
/assign @yanavlasov PTAL. Thanks! |
Signed-off-by: Tianyu Xia <tyxia@google.com>
markdroth
suggested changes
Apr 18, 2022
Contributor
|
@yanavlasov ping! |
yanavlasov
approved these changes
Apr 26, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…roxy#20831) Signed-off-by: Tianyu Xia <tyxia@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapis not needed for the audience url (and no lookup is performed anyway because the key is currently a fixed string..). The audience URL is provided to the filer extension through cluster'styped_filter_metadata. And the cluster selection is based on the information in each route :context_.clusterManager().getThreadLocalCluster(route->routeEntry()->clusterName());.So the correctness of
type_filter_metadatais already guaranteed by the lookup at cluster level (i.e.getThreadLocalCluster()) based on destination cluster information in the route and no lookup of map struct is needed here.Signed-off-by: Tianyu Xia tyxia@google.com