listener: envoy.reloadable_features.listener_reuse_port_default_enabled deprecation#19977
listener: envoy.reloadable_features.listener_reuse_port_default_enabled deprecation#19977mattklein123 merged 3 commits intoenvoyproxy:mainfrom
Conversation
|
/cc @alyssawilk |
giantcroc
changed the title
|
/assign @mattklein123 It seems unclear if we want to remove this now as this might not yet be resolved?
from https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.20.0 |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I think it's OK to remove the runtime flag and just leave the default as disabled for OSX and Windows. Please merge main to fix CI.
/wait
Signed-off-by: changran <changran.wang@intel.com>
|
/wait |
OK, thanks. I will fix it later. |
source/server/server.cc
Outdated
| @@ -530,7 +530,7 @@ void InstanceImpl::initialize(Network::Address::InstanceConstSharedPtr local_add | |||
| : ReusePortDefault::False; | |||
There was a problem hiding this comment.
A question, does it mean the user never can upgrade to the true default value by hot restart? So that means we should keep those code forever?
There was a problem hiding this comment.
@mattklein123 this question probably needs your help. I thought we should remove all the upgrade code. But from the code and comments, I understand the hot restart can't change the default value. That means we only can remove those codes when all the users have a cold restart, but that can't be forced. Then probably this code never can be deleted?
There was a problem hiding this comment.
We don't have a lot of precedent for this. I think technically we could likely remove the code when the last version that had the old default falls out of support. You could leave a comment/TODO about this and we can circle back later? cc @envoyproxy/envoy-maintainers
|
Please run |
Signed-off-by: changran <changran.wang@intel.com>
|
LGTM pending @soulxu comments, thank you. /wait |
Signed-off-by: changran <changran.wang@intel.com>
|
LGTM, thanks for the update! |
RUNTIME_GUARD(envoy_reloadable_features_listener_reuse_port_default_enabled) Was already removed in envoyproxy#19977 but somehow it's back. Fixes envoyproxy#20987 Signed-off-by: Matt Klein <mklein@lyft.com>
RUNTIME_GUARD(envoy_reloadable_features_listener_reuse_port_default_enabled) Was already removed in envoyproxy/envoy#19977 but somehow it's back. Fixes envoyproxy/envoy#20987 Signed-off-by: Matt Klein <mklein@lyft.com>
6 participants
Signed-off-by: changran changran.wang@intel.com
Commit Message: remove envoy.reloadable_features.listener_reuse_port_default_enabled
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]