Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.12.0 proposal #16263

Merged
merged 128 commits into from
Nov 7, 2017
Merged

v6.12.0 proposal #16263

merged 128 commits into from
Nov 7, 2017

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Oct 17, 2017 •
edited
Loading

2017-11-07, Version 6.12.0 'Boron' (LTS), @MylesBorins

This LTS release comes with 127 commits. This includes 45 which are test related,
33 which are doc related, 13 which are updates to dependencies and 7 commits which are related to build / tools.

This release includes a security update to openssl that has been deemed low severity for the Node.js project.

Notable Changes

  • assert:
    • assert.fail() can now take one or two arguments (Rich Trott) #12293
  • crypto:
    • add sign/verify support for RSASSA-PSS (Tobias Nießen) #11705
  • deps:
    • upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691
    • upgrade libuv to 1.15.0 (cjihrig) #15745
    • upgrade libuv to 1.14.1 (cjihrig) #14866
    • upgrade libuv to 1.13.1 (cjihrig) #14117
    • upgrade libuv to 1.12.0 (cjihrig) #13306
  • fs:
    • Add support for fs.write/fs.writeSync(fd, buffer, cb) and fs.write/fs.writeSync(fd, buffer, offset, cb) as documented (Andreas Lind) #7856
  • inspector:
    • enable --inspect-brk (Refael Ackermann) #12615
  • process:
    • add --redirect-warnings command line argument (James M Snell) #10116
  • src:
    • allow CLI args in env with NODE_OPTIONS (Sam Roberts) #12028
    • --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts) #13932
    • allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts) #13172
    • use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts) #12677
  • test:
    • remove common.fail() (Rich Trott) #12293

Commits

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v6.x labels Oct 17, 2017
MylesBorins added a commit that referenced this pull request Oct 17, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
79c7711 
Notable Changes:

Coming Soon

PR-URL: #16263
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Oct 17, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/10787/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1014/
rc.1: https://nodejs.org/download/rc/v6.12.0-rc.1/

evanlucas
evanlucas reviewed Oct 17, 2017
View reviewed changes
doc/changelogs/CHANGELOG_V6.md Outdated
@@ -53,6 +54,124 @@
[Node.js Long Term Support Plan](https://github.com/nodejs/LTS) and
will be supported actively until April 2018 and maintained until April 2019.

<a id="6.12.0"></a>
## 2017-11-07, Version 6.12.9 'Boron' (LTS), @MylesBorins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 6.12.0 instead of Version 6.12.9

@gibfahn
Copy link
Member

gibfahn commented Oct 19, 2017

@MylesBorins https://nodejs.org/download/rc/v6.12.0-rc.1/ is 404ing for me

image

MylesBorins added a commit that referenced this pull request Oct 19, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
39d694c 
Notable Changes:

Coming Soon

PR-URL: #16263
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Oct 19, 2017 •
edited
Loading

ci: https://ci.nodejs.org/job/node-test-pull-request/10861/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1021/
rc.2: https://nodejs.org/download/rc/v6.12.0-rc.2/

refack and others added 10 commits October 25, 2017 04:09
@refack @MylesBorins
inspector: enable --inspect-brk
e31ab7c 
PR-URL: #12615
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tniessen @MylesBorins
crypto: add sign/verify support for RSASSA-PSS
a7d4cad 
Adds support for the PSS padding scheme. Until now, the sign/verify
functions used the old EVP_Sign*/EVP_Verify* OpenSSL API, making it
impossible to change the padding scheme. Fixed by first computing the
message digest and then signing/verifying with a custom EVP_PKEY_CTX,
allowing us to specify options such as the padding scheme and the PSS
salt length.

Fixes: #1127
PR-URL: #11705
Reviewed-By: Shigeki Ohtsu <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott @MylesBorins
assert: improve assert.fail() API
4917d8c 
assert.fail() has two possible function signatures, both of which are
not intuitive. It virtually guarantees that people who try to use
assert.fail() without carefully reading the docs will end up using it
incorrectly.

This change maintains backwards compatibility with the two valid uses
(arguments 1 2 and 4 supplied but argument 3 falsy, and argument 3
supplied but arguments 1 2 and 4 all falsy) but also adds the far more
intuitive first-argument-only and first-two-arguments-only
possibilities.

assert.fail('boom');
// AssertionError: boom

assert.fail('a', 'b');
// AssertionError: 'a' != 'b'

Backport-PR-URL: #15479
PR-URL: #12293
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott @MylesBorins
tools: remove assert.fail() lint rule
44cc39d 
assert.fail() has been updated to accept a single argument so that is no
longer an error. Remove lint rule that checks for assert.fail() with a
single argument.

Backport-PR-URL: #15479
PR-URL: #12293
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott @MylesBorins
test: remove common.fail()
1091b86 
common.fail() was added to paste over issues with assert.fail() function
signature. assert.fail() has been updated to accept a single argument so
common.fail() is no longer necessary.

Backport-PR-URL: #15479
PR-URL: #12293
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig @MylesBorins
test: add cwd ENOENT known issue test
d8f5637 
If the current working directory is removed, Node cannot
start normally because the module system calls uv_cwd().

Backport-PR-URL: #15479
Refs: #12022
PR-URL: #12343
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@lance @MylesBorins
repl: force editorMode in .load
02b4684 
The `.load` command would fail with any file that contains
multiline `.` operator expressions. This was particularly
noticeable when chaining promises or multi-line arrow
expressions.

This change Forces the REPL to be in `editorMode` while loading
a file from disk using the `.load` command.

Fixes: #14022

Backport-PR-URL: #15775
PR-URL: #14861
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins
doc: fix the description of 'close' event
9ec87dc 
PR-URL: #15800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@ofrobots @MylesBorins
deps: V8: backport e560815 from upstream
2d3e735 
Original commit message:
  [runtime] Fix Array.prototype.concat with complex @@species
  Array.prototype.concat does not properly handle JSProxy species that will
  modify the currently visited array.

  BUG=682194

  Review-Url: https://codereview.chromium.org/2655623004
  Cr-Commit-Position: refs/heads/master@{#42640}

Refs: #12779

PR-URL: #16133
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell @MylesBorins
process: add --redirect-warnings command line argument
16802c0 
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.

Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.

If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.

If the file already exists, it will be appended to.

Backport-PR-URL: #12677
PR-URL: #10116
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michal Zasso <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
shigeki and others added 8 commits November 3, 2017 12:29
@shigeki @MylesBorins
deps: copy all openssl header files to include dir
265d948 
All symlink files in `deps/openssl/openssl/include/openssl/`
are removed and replaced with real header files to avoid
issues on Windows. Two files of opensslconf.h in crypto and
include dir are replaced to refer config/opensslconf.h.

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@indutny @MylesBorins
deps: fix openssl assembly error on ia32 win32
7b93a2f 
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
perhaps others) are requiring .686 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Shigeki Ohtsu <[email protected]>
@MylesBorins
deps: fix asm build error of openssl in x86_win32
ef57db8 
See
https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html

iojs needs to stop using masm and move to nasm or yasm on Win32.

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins
openssl: fix keypress requirement in apps on win32
880fba9 
Reapply b910613 .

Fixes: #589
PR-URL: #1389
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins
deps: add -no_rand_screen to openssl s_client
5da4ceb 
In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

Fixes: #1461
PR-URL: #1836
Reviewed-By: Ben Noordhuis <[email protected]>
@shigeki @MylesBorins
deps: update openssl asm and asm_obsolete files
748d3e5 
Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
version was 5.4.0 and nasm version was 2.11.08.

Also asm files in asm_obsolete dir to support old compiler and
assembler are regenerated without CC and ASM envs.

PR-URL: #16691
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn @MylesBorins
doc: standardize function param/object prop style
0f3901a 
Backport-PR-URL: #16560
PR-URL: #13769
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
doc: add 9.x to version picker and mark 8.x as LTS
a776639 
PR-URL: #16672
Fixes: https://github.com/node/issues/16671
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Nov 3, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
1e14191 
Notable Changes:

Coming Soon

PR-URL: #16263
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Nov 3, 2017 •
edited
Loading

ci: https://ci.nodejs.org/job/node-test-pull-request/11175/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1057/
rc.4: https://nodejs.org/download/rc/v6.12.0-rc.4/

v6.11.5 citgm to compare: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1058/

@jasnell
Copy link
Member

jasnell commented Nov 3, 2017

Really not a fan of doing releases on a Friday. Can this wait until monday?

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Nov 3, 2017 via email

@jasnell
Copy link
Member

jasnell commented Nov 3, 2017

Ah ok good. I missed the date in the title

@bzoz @MylesBorins
deps: cherry-pick e7f4e9e from upstream libuv
b98fa82 
Original commit message:
    tty, win: get SetWinEventHook pointer at startup

    SetWinEventHook is not available on some Windows versions.

    Fixes: #16603
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>

PR-URL: #16724
Fixes: #16603
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 4, 2017
Closed
MylesBorins added a commit that referenced this pull request Nov 4, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
b345199 
Notable Changes:

Coming Soon

PR-URL: #16263
@MylesBorins
Copy link
Contributor Author

CI + CITGM look good. Failures are either infra or unrelated to the release

@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
c6a2ec5 
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
@MylesBorins
Copy link
Contributor Author

I've updated with Notable changes... please review and LMK if you see any issues

/cc @sam-github to review the flags stuff

@MylesBorins MylesBorins merged commit c6a2ec5 into v6.x Nov 7, 2017
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
70dc6d5 
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
@MylesBorins MylesBorins mentioned this pull request Nov 7, 2017
Merged
@gibfahn gibfahn deleted the v6.12.0-proposal branch November 7, 2017 18:48
@janlazo janlazo mentioned this pull request Dec 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanlucas evanlucas evanlucas left review comments

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. libuv Issues and PRs related to the libuv dependency or the uv binding. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.