doc: update AUTHORS list #15181

targos · 2017-09-04T13:29:26Z

Update AUTHORS list using tools/update-authors.sh.

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

targos · 2017-09-04T13:31:45Z

There may be a few duplicates but this adds 282 new collaborators since the last update that was 4 months ago 🎉

lpinca · 2017-09-04T13:56:22Z

AUTHORS

+liusi <[email protected]>
+Noj Vek <[email protected]>
+Ruslan Bekenev <[email protected]>
+Danny Nemer <[email protected]>


lpinca · 2017-09-04T13:56:43Z

AUTHORS

+Chris Burkhart <[email protected]>
+Rj Bernaldo <[email protected]>
+John F. Mercer <[email protected]>
+Pedro lima <[email protected]>


lpinca · 2017-09-04T13:57:06Z

AUTHORS

+Griffith Tchenpan <[email protected]>
+Oky Antoro <[email protected]>
+icarter09 <[email protected]>
+Saad Quadri <[email protected]>


TimothyGu · 2017-09-04T14:30:38Z

AUTHORS

+Artur Vieira <[email protected]>
+Flarna <[email protected]>
+kysnm <[email protected]>
+Artur G Vieira <[email protected]>


Dup of 1504.

TimothyGu · 2017-09-04T14:34:02Z

AUTHORS

+Madara Uchiha <[email protected]>
+Gil Tayar <[email protected]>
+Glenn Schlereth <[email protected]>
+Michael Dawson <[email protected]>


Maybe a dupe? @mhdawson can you confirm?

It's a dupe

TimothyGu · 2017-09-04T14:34:42Z

AUTHORS

+Artur G Vieira <[email protected]>
+Sreepurna Jasti <[email protected]>
+Rafael Fragoso <[email protected]>
+daniel.bevenius <[email protected]>


TimothyGu · 2017-09-04T14:35:39Z

AUTHORS

+Ankit Parashar <[email protected]>
+James Kyle <[email protected]>
+Daniil Shakir <[email protected]>
+davidmarkclements <[email protected]>


TimothyGu · 2017-09-04T14:51:33Z

AUTHORS

+Christian d'Heureuse <[email protected]>
+Shahar Or <[email protected]>
+detailyang <[email protected]>
+jBarz <[email protected]>


TimothyGu · 2017-09-04T14:53:00Z

AUTHORS

+Uppinder Chugh <[email protected]>
+Karl Cheng <[email protected]>
+Taylor Woll <[email protected]>
+taylor.woll <[email protected]>


Dupe of the line above.

TimothyGu · 2017-09-04T14:55:34Z

AUTHORS

+Paul Bininda <[email protected]>
+sreepurnajasti <[email protected]>
+Gautam Mittal <[email protected]>
+Jamen Marz <[email protected]>


Dupe of 1543

TimothyGu · 2017-09-04T14:57:28Z

AUTHORS

+Mandeep Singh <[email protected]>
+Prakash Palaniappan <[email protected]>
+Keita Akutsu <[email protected]>
+Gareth Ellis <[email protected]>


Dupe. Different email address though.

TimothyGu

LGTM with those fixed.

benjamingr · 2017-09-04T21:02:31Z

AUTHORS

+Steven Lehn <[email protected]>
+Łukasz Szewczak <[email protected]>
+Madara Uchiha <[email protected]>
+Gil Tayar <[email protected]>


@giltayar @MadaraUchiha

benjamingr · 2017-09-04T21:02:49Z

AUTHORS

+Rob Wu <[email protected]>
+Steven Winston <[email protected]>
+sallen450 <[email protected]>
+OriLev <[email protected]>


benjamingr · 2017-09-04T21:03:54Z

AUTHORS

+Zhang Weijie <[email protected]>
+Gunar C. Gessner <[email protected]>
+SkyAo <[email protected]>
+Benjamin Gruenbaum <[email protected]>


This is most likely a duplicate of [email protected] (work mail vs. old personal mail)

silverwind · 2017-09-04T21:21:10Z

Instead of removing duplicates, you should use .mailmap to alias them instead. That way, the next time this file is regenerated, you don't have to dedupe the same users again.

LakshmiSwethaG · 2017-09-05T07:21:09Z

@targos, thanks for this. I have since then changed my organization, and therefore the email IDs too. Can you please replace [email protected] with [email protected]?
thanks in advance."

targos · 2017-09-05T07:29:40Z

@silverwind do you know how it works? Because for example Ben keeps being added even though all his addresses are in the .mailmap

mhdawson

LGTM

silverwind · 2017-09-05T15:19:51Z

@targos I'm pretty sure that Ben's entry in .mailmap is invalid:

Ben Noordhuis <[email protected]> <bnoordhuis@bender.(none)> <[email protected]>

Acorrding to the shortlog docs, a mailmap entry can either contain a mail address or a mail address and a name after the "proper name and address", and certainly not three adresses so corrected, it should be:

Ben Noordhuis <[email protected]> <bnoordhuis@bender.(none)>
Ben Noordhuis <[email protected]> <[email protected]>

From a quick look, I think this is the only error in the current .mailmap.

targos · 2017-09-05T15:31:12Z

@silverwind Thank you, I understand now. Updating...

bidipyne · 2017-09-05T16:05:55Z

@targos, thanks a lot. Since then, I have changed my organization, and therefore email IDs too. Can you please replace my mail IDs [email protected] to [email protected]?
Thank You!

200GAUTAM · 2017-09-05T16:46:08Z

@targos, thanks a lot. Since then, I have changed my organization, and therefore email IDs too. Can you please replace my mail IDs [email protected] to [email protected]?
Thank You!

sreepurnajasti · 2017-09-06T05:20:20Z

AUTHORS

+Artur Vieira <[email protected]>
+Flarna <[email protected]>
+kysnm <[email protected]>
+Sreepurna Jasti <[email protected]>


@targos As I have changed my organization, I would request you to update this with my personal email id: [email protected]. Thanks in advance.

sreepurnajasti · 2017-09-06T05:21:41Z

AUTHORS

+Alexander O'Mara <[email protected]>
+James, please <[email protected]>
+Josh Ferge <[email protected]>
+sreepurnajasti <[email protected]>


@targos As I have changed my organization, I would request you to update this with my personal email id: [email protected].

Thanks in advance.

XadillaX

LGTM

targos · 2017-09-06T07:19:23Z

@LakshmiSwethaG, @bidipyne, @sreepurnajasti I changed your emails in the map.
@200GAUTAM I think it's already fine for you?

targos · 2017-09-06T07:22:36Z

@lpinca @TimothyGu @XadillaX @mhdawson @silverwind I made a significant change since last review. Now the mailmap is up to date and running tools/update-authors.sh creates the AUTHORS file as it is in my branch.

TimothyGu · 2017-09-06T09:20:30Z

.mailmap

 Onne Gorter <[email protected]>
 Paul Querna <[email protected]> <[email protected]>
+Pedro Lima <[email protected]> Pedro Victor <[email protected]>
+Pedro Lima <[email protected]> Pedro Lima <[email protected]>


Is this line needed?

It is, but I made a typo. It's a version of the name with lowercase "L". Weird that it was working with that mistake...

TimothyGu

mailmap is 🥇

200GAUTAM · 2017-09-06T11:21:48Z

@targos yes [email protected] was already there , Sorry for the confusion

targos · 2017-09-06T11:29:17Z

I searched for all remaining duplicate email addresses in AUTHORS and added them to the map

TimothyGu · 2017-09-06T12:51:58Z

AUTHORS

@@ -1102,16 +1102,14 @@ Michael-Rainabba Richardson <[email protected]>
 oogz <[email protected]>
 Rene Weber <[email protected]>
 Lauren Spiegel <[email protected]>
-Lydia Katsamberis <[email protected]>
+Lydia Kats <[email protected]>


I assume the first one is a more formal name?

I chose the one that is on their GitHub profile: https://github.com/llkats

silverwind

Approach LGTM

Update AUTHORS list using tools/update-authors.sh.

targos · 2017-09-12T08:13:28Z

Landed in 3f7813b

Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: #15181 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: nodejs#15181 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: #15181 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 4, 2017

lpinca reviewed Sep 4, 2017

View reviewed changes

lpinca approved these changes Sep 4, 2017

View reviewed changes

TimothyGu reviewed Sep 4, 2017

View reviewed changes

TimothyGu approved these changes Sep 4, 2017

View reviewed changes

benjamingr reviewed Sep 4, 2017

View reviewed changes

mhdawson approved these changes Sep 5, 2017

View reviewed changes

sreepurnajasti reviewed Sep 6, 2017

View reviewed changes

XadillaX approved these changes Sep 6, 2017

View reviewed changes

targos force-pushed the update-authors branch from d9c2a76 to 8a568b4 Compare September 6, 2017 07:18

gireeshpunathil approved these changes Sep 6, 2017

View reviewed changes

TimothyGu reviewed Sep 6, 2017

View reviewed changes

TimothyGu approved these changes Sep 6, 2017

View reviewed changes

benjamingr approved these changes Sep 6, 2017

View reviewed changes

TimothyGu reviewed Sep 6, 2017

View reviewed changes

silverwind approved these changes Sep 6, 2017

View reviewed changes

jasnell approved these changes Sep 6, 2017

View reviewed changes

doc: update AUTHORS list

cac0d58

Update AUTHORS list using tools/update-authors.sh.

targos force-pushed the update-authors branch from 45edee9 to cac0d58 Compare September 7, 2017 14:55

BridgeAR approved these changes Sep 9, 2017

View reviewed changes

targos closed this Sep 12, 2017

targos deleted the update-authors branch September 12, 2017 08:13

jasnell mentioned this pull request Sep 20, 2017

Node.js 8.6.0 Release Proposal #15509

Merged

MylesBorins added the land-on-v6.x label Oct 17, 2017

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

doc: update AUTHORS list #15181

doc: update AUTHORS list #15181

Conversation

targos commented Sep 4, 2017

Checklist

Affected core subsystem(s)

targos commented Sep 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyGu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

silverwind commented Sep 4, 2017

LakshmiSwethaG commented Sep 5, 2017

targos commented Sep 5, 2017

mhdawson left a comment

Choose a reason for hiding this comment

silverwind commented Sep 5, 2017 • edited Loading

targos commented Sep 5, 2017

bidipyne commented Sep 5, 2017

200GAUTAM commented Sep 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XadillaX left a comment

Choose a reason for hiding this comment

targos commented Sep 6, 2017

targos commented Sep 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimothyGu left a comment

Choose a reason for hiding this comment

200GAUTAM commented Sep 6, 2017

targos commented Sep 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

silverwind left a comment

Choose a reason for hiding this comment

targos commented Sep 12, 2017

silverwind commented Sep 5, 2017 •

edited

Loading