Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced literals in errors with templates #15911

Closed
wants to merge 1 commit into from
Closed

test: replaced literals in errors with templates #15911

wants to merge 1 commit into from

Conversation

domrein
Copy link

@domrein domrein commented Oct 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
Trott
Trott approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Oct 8, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10505/

@Trott Trott self-assigned this Oct 9, 2017
@Trott
Copy link
Member

Trott commented Oct 9, 2017

Landed in 7a8d51c

@Trott Trott closed this Oct 9, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 9, 2017
@domrein @Trott
test: replaced literals in errors with templates
7a8d51c 
PR-URL: nodejs#15911
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 9, 2017

Thanks for the contribution! 🎉

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@domrein @MylesBorins
test: replaced literals in errors with templates
e7c55bf 
PR-URL: #15911
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@domrein @addaleax
test: replaced literals in errors with templates
333db4d 
PR-URL: nodejs/node#15911
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@domrein @MylesBorins
test: replaced literals in errors with templates
44f3efc 
PR-URL: #15911
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@domrein @MylesBorins
test: replaced literals in errors with templates
c86643c 
PR-URL: #15911
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@domrein @MylesBorins
test: replaced literals in errors with templates
ad69a65 
PR-URL: #15911
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

Assignees

@Trott Trott

Labels
buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@domrein @Trott @BridgeAR @mscdex @MylesBorins @nodejs-github-bot