Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade libuv to 1.14.1 #14866

Merged
merged 1 commit into from
Sep 6, 2017
Merged

deps: upgrade libuv to 1.14.1 #14866

merged 1 commit into from
Sep 6, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 16, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Aug 16, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 16, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9690/

refack
refack approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 16, 2017

This appears to break test-setproctitle.js. My first guess is libuv/libuv#1396 for the culprit.

@cjihrig cjihrig mentioned this pull request Aug 16, 2017
Closed
@Daniel15 Daniel15 mentioned this pull request Aug 17, 2017
Closed
@cjihrig cjihrig mentioned this pull request Aug 20, 2017
Merged
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Aug 20, 2017

Should land with #14950 if backported to LTS.

@refack
Copy link
Contributor

refack commented Aug 20, 2017

Sanity CI: https://ci.nodejs.org/job/node-test-commit-linuxone/8123/

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 20, 2017

A full CI run I started last night is here: https://ci.nodejs.org/job/node-test-commit/11914/

The second commit in this PR still needs to land and be released in libuv. The Windows failures here are addressed by #14950. Still looking into some other failures though.

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 20, 2017

@gibfahn any idea what's going on with https://ci.nodejs.org/job/node-test-commit-freebsd/11111/nodes=freebsd10-64/ ?

@gibfahn
Copy link
Member

gibfahn commented Aug 20, 2017

@gibfahn any idea what's going on with https://ci.nodejs.org/job/node-test-commit-freebsd/11111/nodes=freebsd10-64/ ?

Odd, seems to have just gotten stuck. I killed the job, cleaned up the processes, and rebooted. Hopefully that'll sort it.

@XadillaX
Copy link
Contributor

Note it fixes #13581.

@XadillaX XadillaX mentioned this pull request Aug 21, 2017
Closed
cjihrig added a commit to cjihrig/node that referenced this pull request Aug 22, 2017
@cjihrig
test: update windows module load error message
9eb8f44 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: nodejs#14866
PR-URL: nodejs#14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@cjihrig @addaleax
test: update windows module load error message
dd29648 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: nodejs/node#14866
PR-URL: nodejs/node#14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig mentioned this pull request Aug 25, 2017
Merged
4 tasks
@refack
Copy link
Contributor

refack commented Aug 27, 2017

And it fixes #12737

@refack refack mentioned this pull request Aug 27, 2017
Closed
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@cjihrig @addaleax
test: update windows module load error message
40adc2c 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: nodejs/node#14866
PR-URL: nodejs/node#14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bzoz bzoz mentioned this pull request Aug 28, 2017
Closed
@cjihrig
deps: upgrade libuv to 1.14.1
8485a7c 
Fixes: nodejs#12737
Fixes: nodejs#13581
Fixes: nodejs#15117
PR-URL: nodejs#14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig changed the title deps: upgrade libuv to 1.14.0 deps: upgrade libuv to 1.14.1 Sep 6, 2017
@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 6, 2017

New CI with libuv 1.14.1: https://ci.nodejs.org/job/node-test-pull-request/9960/

@cjihrig cjihrig merged commit 8485a7c into nodejs:master Sep 6, 2017
@cjihrig cjihrig deleted the libuv branch September 6, 2017 16:49
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@cjihrig @MylesBorins
test: update windows module load error message
6263e01 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.14.1
5ce569c 
Fixes: #12737
Fixes: #13581
Fixes: #15117
PR-URL: #14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.14.1
a9cfdea 
Fixes: #12737
Fixes: #13581
Fixes: #15117
PR-URL: #14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@cjihrig @MylesBorins
test: update windows module load error message
e244f84 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.14.1
acf9650 
Fixes: #12737
Fixes: #13581
Fixes: #15117
PR-URL: #14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins added a commit that referenced this pull request Sep 12, 2017
@MylesBorins
2017-09-12, Version 8.5.0 (Current)
a2a2ff4 
Notable Changes

* build:
  * Snapshots are now re-enabled in V8
  #14875

* console:
  * Implement minimal `console.group()`.
  #14910

* deps:
  * upgrade libuv to 1.14.1
    #14866
  * update nghttp2 to v1.25.0
    #14955

* dns:
  * Add `verbatim` option to dns.lookup(). When true, results from the
    DNS resolver are passed on as-is, without the reshuffling that
    Node.js otherwise does that puts IPv4 addresses before IPv6
    addresses.
    #14731

* fs:
  * add fs.copyFile and fs.copyFileSync which allows for more efficient
    copying of files.
    #15034

* inspector:
  * Enable async stack traces
    #13870

* module:
  * Add support for ESM. This is currently behind the
    `--experimental-modules` flag and requires the .mjs extension.
    `node --experimental-modules index.mjs`
    #14369

* napi:
  * implement promise
    #14365

* os:
  * Add support for CIDR notation to the output of the
    networkInterfaces() method.
    #14307

* perf_hooks:
  * An initial implementation of the Performance Timing API for
    Node.js. This is the same Performance Timing API implemented by
    modern browsers with a number of Node.js specific properties. The
    User Timing mark() and measure() APIs are implemented, as is a
    Node.js specific flavor of the Frame Timing for measuring event
    loop duration.
    #14680

* tls:
  * multiple PFX in createSecureContext
    [#14793](#14793)

* Added new collaborators:
  * BridgeAR – Ruben Bridgewater

PR-URL: #15308
MylesBorins added a commit that referenced this pull request Sep 12, 2017
@MylesBorins
2017-09-12, Version 8.5.0 (Current)
a10856a 
Notable Changes

* build:
  * Snapshots are now re-enabled in V8
  #14875

* console:
  * Implement minimal `console.group()`.
  #14910

* deps:
  * upgrade libuv to 1.14.1
    #14866
  * update nghttp2 to v1.25.0
    #14955

* dns:
  * Add `verbatim` option to dns.lookup(). When true, results from the
    DNS resolver are passed on as-is, without the reshuffling that
    Node.js otherwise does that puts IPv4 addresses before IPv6
    addresses.
    #14731

* fs:
  * add fs.copyFile and fs.copyFileSync which allows for more efficient
    copying of files.
    #15034

* inspector:
  * Enable async stack traces
    #13870

* module:
  * Add support for ESM. This is currently behind the
    `--experimental-modules` flag and requires the .mjs extension.
    `node --experimental-modules index.mjs`
    #14369

* napi:
  * implement promise
    #14365

* os:
  * Add support for CIDR notation to the output of the
    networkInterfaces() method.
    #14307

* perf_hooks:
  * An initial implementation of the Performance Timing API for
    Node.js. This is the same Performance Timing API implemented by
    modern browsers with a number of Node.js specific properties. The
    User Timing mark() and measure() APIs are implemented, as is a
    Node.js specific flavor of the Frame Timing for measuring event
    loop duration.
    #14680

* tls:
  * multiple PFX in createSecureContext
    [#14793](#14793)

* Added new collaborators:
  * BridgeAR – Ruben Bridgewater

PR-URL: #15308
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@cjihrig @addaleax
deps: upgrade libuv to 1.14.1
66527af 
Fixes: nodejs#12737
Fixes: nodejs#13581
Fixes: nodejs#15117
PR-URL: nodejs#14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@MylesBorins @addaleax
2017-09-12, Version 8.5.0 (Current)
ad2a0b2 
Notable Changes

* build:
  * Snapshots are now re-enabled in V8
  nodejs#14875

* console:
  * Implement minimal `console.group()`.
  nodejs#14910

* deps:
  * upgrade libuv to 1.14.1
    nodejs#14866
  * update nghttp2 to v1.25.0
    nodejs#14955

* dns:
  * Add `verbatim` option to dns.lookup(). When true, results from the
    DNS resolver are passed on as-is, without the reshuffling that
    Node.js otherwise does that puts IPv4 addresses before IPv6
    addresses.
    nodejs#14731

* fs:
  * add fs.copyFile and fs.copyFileSync which allows for more efficient
    copying of files.
    nodejs#15034

* inspector:
  * Enable async stack traces
    nodejs#13870

* module:
  * Add support for ESM. This is currently behind the
    `--experimental-modules` flag and requires the .mjs extension.
    `node --experimental-modules index.mjs`
    nodejs#14369

* napi:
  * implement promise
    nodejs#14365

* os:
  * Add support for CIDR notation to the output of the
    networkInterfaces() method.
    nodejs#14307

* perf_hooks:
  * An initial implementation of the Performance Timing API for
    Node.js. This is the same Performance Timing API implemented by
    modern browsers with a number of Node.js specific properties. The
    User Timing mark() and measure() APIs are implemented, as is a
    Node.js specific flavor of the Frame Timing for measuring event
    loop duration.
    nodejs#14680

* tls:
  * multiple PFX in createSecureContext
    [nodejs#14793](nodejs#14793)

* Added new collaborators:
  * BridgeAR – Ruben Bridgewater

PR-URL: nodejs#15308
@MylesBorins
Copy link
Contributor

This should likely come with the libuv 1.14.0 upgrade if we do it in the next minor

/cc @nodejs/lts

@Fishrock123
Copy link
Contributor

This was only in a live release for a week though? seems like 1.14.1 at least should have more time.

@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 20, 2017

There is no 1.14.0 update. We skipped directly to 1.14.1 because of a regression in uv_set_process_title().

MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.14.1
efc3530 
Fixes: #12737
Fixes: #13581
Fixes: #15117
PR-URL: #14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
@cjihrig @MylesBorins
test: update windows module load error message
eb2a0db 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.14.1
08d6830 
Fixes: #12737
Fixes: #13581
Fixes: #15117
PR-URL: #14866
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@cjihrig @MylesBorins
test: update windows module load error message
4030c7e 
libuv 1.14.0 includes a fix for the "%1 is not a valid Win32
application" error message.

Refs: #14866
PR-URL: #14950
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
MylesBorins added a commit that referenced this pull request Nov 6, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
c6a2ec5 
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
70dc6d5 
Notable Changes:

* assert:
  - assert.fail() can now take one or two arguments (Rich Trott)
    #12293
* crypto:
  - add sign/verify support for RSASSA-PSS (Tobias Nießen)
    #11705
* deps:
  - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
    #16691
  - upgrade libuv to 1.15.0 (cjihrig)
    #15745
  - upgrade libuv to 1.14.1 (cjihrig)
    #14866
  - upgrade libuv to 1.13.1 (cjihrig)
    #14117
  - upgrade libuv to 1.12.0 (cjihrig)
    #13306
* fs:
  - Add support for fs.write/fs.writeSync(fd, buffer, cb) and
    fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
    (Andreas Lind) #7856
* inspector:
  - enable --inspect-brk (Refael Ackermann)
    #12615
* process:
  - add --redirect-warnings command line argument (James M Snell)
    #10116
* src:
  - allow CLI args in env with NODE_OPTIONS (Sam Roberts)
    #12028)
  - --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
    #13932
  - allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
    #13172
  - use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
    #12677
* test:
  - remove common.fail() (Rich Trott)
    #12293

PR-URL: #16263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @gibfahn @refack @XadillaX @MylesBorins @Fishrock123 @jasnell @nodejs-github-bot