Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: truncate 'close' event descriptions for fs.ReadStream and fs.WriteStream #15800

Closed
wants to merge 1 commit into from
Closed

Conversation

JamesMGreene
Copy link
Contributor

Per suggestion from @mscdex in PR #15790

Checklist
Affected core subsystem(s)

doc


As with PR #15790, I tried to follow the commit message guidelines but I couldn't think any of good message that was 50 characters or less. If anyone has recommendations, I'd be happy to update it.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Oct 6, 2017
@joyeecheung
Copy link
Member

Landed in 20f8a22, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@JamesMGreene JamesMGreene deleted the doc_clean branch October 11, 2017 14:40
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#15800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins added a commit that referenced this pull request Oct 12, 2017
PR-URL: #15800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
targos pushed a commit that referenced this pull request Oct 18, 2017
PR-URL: #15800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins added a commit that referenced this pull request Oct 25, 2017
PR-URL: #15800
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants