doc: truncate 'close' event descriptions for fs.ReadStream and fs.WriteStream #15800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
2 tasks
lpinca
approved these changes
Oct 9, 2017
TimothyGu
approved these changes
Oct 9, 2017
joyeecheung
approved these changes
Oct 11, 2017
|
Landed in 20f8a22, thanks for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15800 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15800 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
added a commit
that referenced
this pull request
Oct 12, 2017
PR-URL: #15800 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15800 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
added a commit
that referenced
this pull request
Oct 25, 2017
PR-URL: #15800 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion from @mscdex in PR #15790
Checklist
Affected core subsystem(s)
doc
As with PR #15790, I tried to follow the commit message guidelines but I couldn't think any of good message that was 50 characters or less. If anyone has recommendations, I'd be happy to update it.