Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-http-agent-maxsockets robust #15192

Closed
wants to merge 1 commit into from
Closed

test: make test-http-agent-maxsockets robust #15192

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 5, 2017

On a slow/busy machine, test-http-agent-maxsockets can fail if the
test takes longer than 5 seconds because that is the default value for
server.keepAliveTimeout. Disable keepAliveTimeout to make the test
robust.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test http

@Trott
test: make test-http-agent-maxsockets robust
65fd5c2 
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.
@Trott Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Sep 5, 2017
@BridgeAR
Copy link
Member

Landed in aa3b96a

@BridgeAR BridgeAR closed this Sep 11, 2017
BridgeAR pushed a commit that referenced this pull request Sep 11, 2017
@Trott @BridgeAR
test: make test-http-agent-maxsockets robust
aa3b96a 
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.

PR-URL: #15192
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@Trott @addaleax
test: make test-http-agent-maxsockets robust
f23ca1c 
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.

PR-URL: nodejs#15192
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@Trott @jasnell
test: make test-http-agent-maxsockets robust
a92f3df 
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.

PR-URL: #15192
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@Trott @MylesBorins
test: make test-http-agent-maxsockets robust
845c739 
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.

PR-URL: #15192
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@Trott @MylesBorins
test: make test-http-agent-maxsockets robust
514ef74 
On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.

PR-URL: #15192
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
@Trott Trott deleted the server-keepalivetimeout branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @BridgeAR @jasnell @lpinca @cjihrig @tniessen @MylesBorins