Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix some internal links #15293

Closed
wants to merge 2 commits into from
Closed

doc: fix some internal links #15293

wants to merge 2 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 9, 2017
This was referenced Sep 10, 2017
Closed
Closed
targos
targos reviewed Sep 10, 2017
View reviewed changes
doc/api/http2.md
@@ -1505,8 +1505,7 @@ added: v8.4.0
* `options` {Object}
* `allowHTTP1` {boolean} Incoming client connections that do not support
HTTP/2 will be downgraded to HTTP/1.x when set to `true`. The default value
is `false`. See the [`'unknownProtocol'`][] event. See [ALPN
negotiation](#alpn-negotiation).
is `false`. See the [`'unknownProtocol'`][] event. See [ALPN negotiation][].
Copy link
Member

@targos targos Sep 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is now 81 chars long. I suggest:

See the [`'unknownProtocol'`][] event and [ALPN negotiation][].

Edit: actual suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it is exactly 80 chars currently.

doc/api/http2.md Outdated
@@ -2680,12 +2679,13 @@ if the stream is closed.
[`EventEmitter`]: events.html#events_class_eventemitter
[`Http2Stream`]: #http2_class_http2stream
[`ServerHttp2Stream`]: #http2_class_serverhttp2stream
[`ServerRequest`]: #http2_class_server_request
[`ServerRequest`]: #http2_class_http2_http2serverrequest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Http2ServerRequest. You'll have to change its usage higher in the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

vsemozhetbyt added a commit that referenced this pull request Sep 12, 2017
@vsemozhetbyt
doc: fix some internal links
da057db 
PR-URL: #15293
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

Landed in da057db

@vsemozhetbyt vsemozhetbyt deleted the doc-hashes branch September 12, 2017 14:06
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@vsemozhetbyt @addaleax
doc: fix some internal links
855aea7 
PR-URL: nodejs#15293
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 20, 2017

this would need to be backported to v8.x

@vsemozhetbyt vsemozhetbyt mentioned this pull request Sep 20, 2017
Closed
2 tasks
@vsemozhetbyt
Copy link
Contributor Author

@jasnell Done: #15495

jasnell pushed a commit that referenced this pull request Sep 20, 2017
@vsemozhetbyt @jasnell
doc: fix some internal links
4efc6fe 
PR-URL: #15293
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 17, 2017
Closed
2 tasks
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Oct 17, 2017 •
edited
Loading

@MylesBorins Backport: #16254

MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@vsemozhetbyt @MylesBorins
doc: fix some internal links
860be62 
PR-URL: #15293
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@vsemozhetbyt @MylesBorins
doc: fix some internal links
ccdc194 
PR-URL: #15293
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@claudiorodriguez claudiorodriguez claudiorodriguez approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.