doc: replace string concatenations with template literals #16046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
BridgeAR
reviewed
Oct 6, 2017
| return cb(new Error('Inappropriate heading level\n' + | ||
| JSON.stringify(tok))); | ||
| return cb(new Error(`Inappropriate heading level | ||
| ${JSON.stringify(tok)}`)); |
There was a problem hiding this comment.
Nit - we actually prefer not to use multiline template strings. This should likely be changed while landing and we might think about adding a eslint rule against this as it comes up more often.
There was a problem hiding this comment.
The same applies to the other template strings in here.
BridgeAR
approved these changes
Oct 6, 2017
|
The subsystem has to be changed to tools while landing. |
Trott
added
the
code-and-learn
lance
approved these changes
Oct 7, 2017
|
Landed in 9f98989 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #16046 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #16046 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#16046 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
PR-URL: #16046 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #16046 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
PR-URL: #16046 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tooks