test: clarify assert messages #16019

cpandrews8 · 2017-10-06T19:05:53Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

test

BridgeAR

LGTM

BridgeAR · 2017-10-06T21:26:11Z

test/parallel/test-crypto-sign-verify.js

@@ -23,7 +23,7 @@ const modSize = 1024;
  let s1stream = crypto.createSign('SHA1');
  s1stream.end('Test123');
  s1stream = s1stream.sign(keyPem, 'base64');
-  assert.strictEqual(s1, s1stream, 'Stream produces same output');
+  assert.strictEqual(s1, s1stream, `${s1} should equal ${s1stream}`);


Nice! The former message was actually really wrong!

lance · 2017-10-09T19:28:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10544/

lance · 2017-10-09T21:46:03Z

Gee whiz, the flakiness of CI can be burdensome sometimes. Looks like all CI issues are completely unrelated. Otherwise everything is green. I'm going to land this.

Documenting here, just for the record.

aix61-ppc64

not ok 1787 inspector/test-stop-profile-after-done # TODO : Fix flaky test
  ---
  duration_ms: 1.89
  severity: flaky
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:47668/47743230-a589-4405-9c67-1eda00de594c
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] {}
    [out] {}
    [out] {}
    [out] 
    { Error: connect ECONNREFUSED 127.0.0.1:47668
        at Object._errnoException (util.js:1023:13)
        at _exceptionWithHostPort (util.js:1044:20)
        at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1179:14)
      errno: 'ECONNREFUSED',
      code: 'ECONNREFUSED',
      syscall: 'connect',
      address: '127.0.0.1',
      port: 47668 }
    1

smartos15-64

not ok 1787 inspector/test-stop-profile-after-done # TODO : Fix flaky test
  ---
  duration_ms: 1.89
  severity: flaky
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:47668/47743230-a589-4405-9c67-1eda00de594c
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] {}
    [out] {}
    [out] {}
    [out] 
    { Error: connect ECONNREFUSED 127.0.0.1:47668
        at Object._errnoException (util.js:1023:13)
        at _exceptionWithHostPort (util.js:1044:20)
        at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1179:14)
      errno: 'ECONNREFUSED',
      code: 'ECONNREFUSED',
      syscall: 'connect',
      address: '127.0.0.1',
      port: 47668 }
    1

vs2017,win2016,0

not ok 465 inspector/test-stop-profile-after-done # TODO : Fix flaky test
  ---
  duration_ms: 0.442
  severity: flaky
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:65443/01093735-5119-48ed-a3f5-072b6f4658b7
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [err] Debugger attached.
    [err] Waiting for the debugger to disconnect...
    [err] 
    { AssertionError [ERR_ASSERTION]: 0 === 3221225477
        at runTests (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\0\test\inspector\test-stop-profile-after-done.js:26:10)
        at 
        at process._tickCallback (internal/process/next_tick.js:188:7)
      generatedMessage: true,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 0,
      expected: 3221225477,
      operator: '===' }
    1
  ...

3,pi3-raspbian-jessie


FATAL: remote file operation failed: /home/iojs/build/workspace/node-test-binary-arm@tmp/secretFiles/d067289f-6ccb-40cd-91e1-59a7b217dffd at hudson.remoting.Channel@44c3e069:JNLP4-connect connection from static-n49-176-213-208.sbr2.nsw.optusnet.com.au/49.176.213.208:48902: java.io.IOException: Unable to delete '/home/iojs/build/workspace/node-test-binary-arm@tmp/secretFiles/d067289f-6ccb-40cd-91e1-59a7b217dffd/.nfs0000000000108f4c0000001d'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
java.nio.file.FileSystemException: /home/iojs/build/workspace/node-test-binary-arm@tmp/secretFiles/d067289f-6ccb-40cd-91e1-59a7b217dffd/.nfs0000000000108f4c0000001d: Device or resource busy
	at sun.nio.fs.UnixException.translateToIOException(UnixException.java:91)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
	at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
	at sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:244)
	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(AbstractFileSystemProvider.java:108)
	at java.nio.file.Files.deleteIfExists(Files.java:1165)
	at hudson.Util.tryOnceDeleteFile(Util.java:287)
	at hudson.Util.deleteFile(Util.java:243)
	at hudson.FilePath.deleteRecursive(FilePath.java:1209)
	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1218)
	at hudson.FilePath.deleteRecursive(FilePath.java:1200)
	at hudson.FilePath.access$1000(FilePath.java:195)
	at hudson.FilePath$14.invoke(FilePath.java:1179)
	at hudson.FilePath$14.invoke(FilePath.java:1176)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2731)
	at hudson.remoting.UserRequest.perform(UserRequest.java:153)
	at hudson.remoting.UserRequest.perform(UserRequest.java:50)
	at hudson.remoting.Request$2.run(Request.java:336)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at hudson.remoting.Engine$1$1.run(Engine.java:94)
	at java.lang.Thread.run(Thread.java:745)
Caused: java.io.IOException: Unable to delete '/home/iojs/build/workspace/node-test-binary-arm@tmp/secretFiles/d067289f-6ccb-40cd-91e1-59a7b217dffd/.nfs0000000000108f4c0000001d'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
	at hudson.Util.deleteFile(Util.java:248)
	at hudson.FilePath.deleteRecursive(FilePath.java:1209)
	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1218)
	at hudson.FilePath.deleteRecursive(FilePath.java:1200)
	at hudson.FilePath.access$1000(FilePath.java:195)
	at hudson.FilePath$14.invoke(FilePath.java:1179)
	at hudson.FilePath$14.invoke(FilePath.java:1176)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2731)
	at hudson.remoting.UserRequest.perform(UserRequest.java:153)
	at hudson.remoting.UserRequest.perform(UserRequest.java:50)
	at hudson.remoting.Request$2.run(Request.java:336)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at hudson.remoting.Engine$1$1.run(Engine.java:94)
	at java.lang.Thread.run(Thread.java:745)
	at ......remote call to JNLP4-connect connection from static-n49-176-213-208.sbr2.nsw.optusnet.com.au/49.176.213.208:48902(Native Method)
	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1545)
	at hudson.remoting.UserResponse.retrieve(UserRequest.java:253)
	at hudson.remoting.Channel.call(Channel.java:830)
	at hudson.FilePath.act(FilePath.java:985)
Caused: java.io.IOException: remote file operation failed: /home/iojs/build/workspace/node-test-binary-arm@tmp/secretFiles/d067289f-6ccb-40cd-91e1-59a7b217dffd at hudson.remoting.Channel@44c3e069:JNLP4-connect connection from static-n49-176-213-208.sbr2.nsw.optusnet.com.au/49.176.213.208:48902
	at hudson.FilePath.act(FilePath.java:992)
	at hudson.FilePath.act(FilePath.java:974)
	at hudson.FilePath.deleteRecursive(FilePath.java:1176)
	at org.jenkinsci.plugins.credentialsbinding.impl.UnbindableDir$UnbinderImpl.unbind(UnbindableDir.java:84)
	at org.jenkinsci.plugins.credentialsbinding.impl.SecretBuildWrapper$1.tearDown(SecretBuildWrapper.java:113)
	at hudson.model.Build$BuildExecution.doRun(Build.java:174)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
	at hudson.model.Run.execute(Run.java:1728)
	at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:405)

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

lance · 2017-10-09T21:46:37Z

Landed in 5f15fde

@cpandrews8 thanks for your contribution! It's much appreciated.

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

PR-URL: nodejs/node#16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

test: clarify assert messages

73de308

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017

mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017

BridgeAR approved these changes Oct 6, 2017

View reviewed changes

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017

lance self-assigned this Oct 9, 2017

lance approved these changes Oct 9, 2017

View reviewed changes

lance pushed a commit that referenced this pull request Oct 9, 2017

test: clarify assert messages in crypto tests

5f15fde

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

lance closed this Oct 9, 2017

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017

test: clarify assert messages in crypto tests

572492a

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

MylesBorins mentioned this pull request Oct 11, 2017

v8.7.0 proposal #15762

Merged

addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017

test: clarify assert messages in crypto tests

172afc0

PR-URL: nodejs/node#16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

MylesBorins pushed a commit that referenced this pull request Oct 17, 2017

test: clarify assert messages in crypto tests

3e5e8cb

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

MylesBorins added the land-on-v6.x label Oct 17, 2017

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins pushed a commit that referenced this pull request Oct 18, 2017

test: clarify assert messages in crypto tests

0c0243a

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

MylesBorins pushed a commit that referenced this pull request Oct 25, 2017

test: clarify assert messages in crypto tests

58509ec

PR-URL: #16019 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

cpandrews8 deleted the test-strict branch November 2, 2018 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: clarify assert messages #16019

test: clarify assert messages #16019

cpandrews8 commented Oct 6, 2017 •

edited by BridgeAR

Loading

BridgeAR left a comment

BridgeAR Oct 6, 2017

lance commented Oct 9, 2017

lance commented Oct 9, 2017

lance commented Oct 9, 2017

test: clarify assert messages #16019

test: clarify assert messages #16019

Conversation

cpandrews8 commented Oct 6, 2017 • edited by BridgeAR Loading

Checklist

Affected core subsystem(s)

BridgeAR left a comment

Choose a reason for hiding this comment

BridgeAR Oct 6, 2017

Choose a reason for hiding this comment

lance commented Oct 9, 2017

lance commented Oct 9, 2017

lance commented Oct 9, 2017

cpandrews8 commented Oct 6, 2017 •

edited by BridgeAR

Loading