Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add hasCrypto check to test-cli-node-options #12692

Closed

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 27, 2017

Currently when configure --without-ssl the test will throw the following
error:

bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 27, 2017
@danbev
Copy link
Contributor Author

danbev commented Apr 27, 2017

@mscdex mscdex added the cli Issues and PRs related to the Node.js command line interface. label Apr 27, 2017
@sam-github
Copy link
Contributor

@nodejs/testing @nodejs/build We need a CI job, probably linux-only would be fine, that does a configure and test without SSL. This fix is only one of a string of fixes that have been made for this. Its really hard to remember such an obscure build case, sorry @danbev

@gibfahn
Copy link
Member

gibfahn commented Apr 27, 2017

@sam-github it's on my list... nodejs/build#643

I'm thinking that another job that runs a variety of targets with different configurations would probably be useful, (we need --without-intl as well)

danbev added a commit to danbev/node that referenced this pull request Apr 29, 2017
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca

This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.

PR-URL: nodejs#12692
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>/
@danbev
Copy link
Contributor Author

danbev commented Apr 29, 2017

Landed in 427cd29

@danbev danbev closed this Apr 29, 2017
@danbev danbev deleted the add-has-crypto-check-cli-node-options branch April 30, 2017 05:39
@jasnell jasnell mentioned this pull request May 11, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Should land with #12677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants