-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add hasCrypto check to test-cli-node-options #12692
Conversation
Currently when configure --without-ssl the test will throw the following error: bad option: --use-openssl-ca This commit checks if crypto was enabled and skips the crypto related tests if that is the case.
@nodejs/testing @nodejs/build We need a CI job, probably linux-only would be fine, that does a configure and test without SSL. This fix is only one of a string of fixes that have been made for this. Its really hard to remember such an obscure build case, sorry @danbev |
@sam-github it's on my list... nodejs/build#643 I'm thinking that another job that runs a variety of targets with different configurations would probably be useful, (we need |
Currently when configure --without-ssl the test will throw the following error: bad option: --use-openssl-ca This commit checks if crypto was enabled and skips the crypto related tests if that is the case. PR-URL: nodejs#12692 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>/
Landed in 427cd29 |
Should land with #12677 |
Currently when configure --without-ssl the test will throw the following
error:
bad option: --use-openssl-ca
This commit checks if crypto was enabled and skips the crypto related
tests if that is the case.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test