Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add kfarnung to collaborators #16108

Closed
wants to merge 1 commit into from
Closed

doc: add kfarnung to collaborators #16108

wants to merge 1 commit into from

Conversation

kfarnung
Copy link
Contributor

@kfarnung kfarnung commented Oct 9, 2017

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 9, 2017
@kfarnung
Copy link
Contributor Author

kfarnung commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10549/

Trott
Trott approved these changes Oct 9, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 9, 2017
refack
refack approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 9, 2017
@kfarnung
doc: add kfarnung to collaborators
f8dd1ac 
PR-URL: nodejs#16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@kfarnung
Copy link
Contributor Author

kfarnung commented Oct 9, 2017

Landed in f8dd1ac

@kfarnung kfarnung closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@kfarnung @MylesBorins
doc: add kfarnung to collaborators
bae46dc 
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@kfarnung @MylesBorins
doc: add kfarnung to collaborators
26b8c8d 
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@kfarnung @MylesBorins
doc: add kfarnung to collaborators
8246306 
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@kfarnung @MylesBorins
doc: add kfarnung to collaborators
c64603f 
PR-URL: #16108
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Bryan English <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bengl bengl bengl approved these changes

@Trott Trott Trott approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kfarnung @refack @bengl @Trott @vsemozhetbyt @MylesBorins @nodejs-github-bot