docs: clarify usage cli options -e,-p on windows #15568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cli
vsemozhetbyt
approved these changes
Sep 23, 2017
refack
reviewed
Sep 23, 2017
doc/api/cli.md
Outdated
| @@ -53,6 +53,11 @@ changes: | |||
| Evaluate the following argument as JavaScript. The modules which are | |||
| predefined in the REPL can also be used in `script`. | |||
|
|
|||
| *Note*: Please use double quote for the `script`, although it does not matter | |||
There was a problem hiding this comment.
@lukaszewczak Thank you for posting this.
I would suggest the following change:
*Note*: On Windows, using `cmd.exe` a single quote will not work correctly
because it only recognizes double `"` for quoting. In Powershell or
Git bash, both `'` and `"` are usable.- Start with
On Windowsso it's clear that the note target Windows behaviur - IMHO there is no need to compare to Linux (also the comparison is with Linux'es shells, the OS does care)
- Mention that it's only
cmd.exe, as PS and bash on windows understand'
There was a problem hiding this comment.
Thank you @refack for your comment. I made a change in note according to your suggestions.
refack
approved these changes
Sep 23, 2017
lpinca
approved these changes
Sep 24, 2017
lpinca
reviewed
Sep 24, 2017
| *Note*: On Windows, using `cmd.exe` a single quote will not work correctly | ||
| because it only recognizes double `"` for quoting. In Powershell or | ||
| Git bash, both `'` and `"` are usable. | ||
|
|
There was a problem hiding this comment.
Tiny nit: can you please remove this spurious new line?
Edit: ignore me it seems to be consistent with the rest of the file.
gibfahn
approved these changes
Sep 24, 2017
BridgeAR
approved these changes
Sep 24, 2017
jasnell
approved these changes
Sep 25, 2017
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2017
PR-URL: #15568 Fixes: #15522 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 7e382c1 |
jasnell
pushed a commit
that referenced
this pull request
Sep 26, 2017
PR-URL: #15568 Fixes: #15522 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2017
PR-URL: #15568 Fixes: #15522 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
PR-URL: nodejs/node#15568 Fixes: nodejs/node#15522 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
PR-URL: #15568 Fixes: #15522 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
PR-URL: #15568 Fixes: #15522 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15522
I open previously Pull Request (#15543), but I decided to close it because I messed a little with a git rebase... I'm sorry for this, but it seams I need to practice more with git..
About the change. So I put note about using double quote for the
scriptonly under option-e, because description under-prefers to option-eso if the user would like to know the whole meaning about option-pwill read description under-ewith this new note.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc