Merged
Conversation
* SpinButton: Cancel the up/down arrow keys when inside of a spinButton to make sure they don't leak outside of the spinButton (especially when inside of a FocusZone) * rush change * Remove extra 's' in the comment I added
…ns from Voice Over (#4510) changed dropdown role from combobox to listbox
* start aria-rowindex from '1' instead of '0' * add change file * Update users-prmutn-ariaRowIndexBugfix_2018-04-11-10-40.json add newline at end
* Add missing hover and activate style slots to DetailsHeader * Fix phantom aria-describedby attribute * Fix overflow of headers caused by status icons * Update change output * Update snapshot output
#4511) * change lets to consts * fix another file * change file
* Fix scroll bar shows when it should not. * rush change * fix using wrong element to calculate root height * Update the code to not use BoundingClientRect since it is too expensive and instead allow for a 1px difference in the height difference calculation.
* Adding the ability to display the ariaLabel instead of the option text. This is necessary for cases where embedded text is used as the option text * change * Adding clarifying comments, fixing style, and adding an aria-label to the checkbox
…container has role list but no list item child is present. (#4531) * added missing role to TagPicker's TagItem * rush change * updated snapshots * updated snapshots again * increased bundlesize limit to 46.2 * this commit is really just to re-run screener
* Wrapping combobox options in an internal component which only performs an update if the props have changed. We are currently updating every option on every mouse or keyboard event. This gives awful performance in comboboxes with many elements. * change * using shallowCompare in shouldComponentUpdate * Bumping the bundle size
* Add EditSection component and some APIs to ComponentPage.
* Add ability to use Customizer to provide a default layer behavior * Update change output
* improve contextualmenu perf and add persist menu to button * keep style in to not be a breaking change * fix comments: * revert max height from state * update comment * improve previous activeelement * fix focus * update snapshot * increase bundle size
* Replaces LINE with line * Replaces CIRCLE with circle. * Replaces GAP with gap. * Replaces CENTER, TOP, BOTTOM with center, top , bottom. * Rush change log. * Adds deprecation warnings to enums.
* Add focus method to Breadcrumb * Add change file * Refactor code based on BaseExtendedPicker.tsx
* Fixes import in ShimmerPage * Fixes imports for a more consistent use pattern across component. * Rush change log.
…o align (#4538) * Fix create-component script to build successfully and documentation to align * more fixes * Fix indents * more indentation fix * fix typo
* Add focus method to Pivot * Add change file * Refactor code based on BaseExtenderPicker.tsx * Switch protected to private
…ble with the auto spell check by Grammarly extension (#4481) * Set Panel's FocusTrapZone allow click interactions while panel is open * use focusTrapZoneProps.isClickableOutsideFocusTrap if set
* Bring back isResultsFooterVisible that is props but never used * npm run change * PR feedback * Default the prop to true and state the default value in comment * Minor changes to close the PR
… container instead of two (#4530) * new split button changes that gets rid of inner container * removed old focus styles * moved class name to be alphabetical * moved class back to where it was before * removed aria hidden for divider as there's no text * added change file * reverted vertical divdier; removed unneeded styles * add space for vertical divider back * bumped bundle size limit * reverted bundle to previous state
…e: when user is in "drag and drop" status (#4546)
…4544) * Prevent SelectionZone from clobbering interactive sub-elements * Add modal selection to DetailsList Advanced example * Update change output
* Adds some more examples. * Adds margin. * Rush change log.
* undo * Adding change file.
* Signed-off-by: Sivaraman Krishnan <sikrishn@microsoft.com> * Signed-off-by: Sivaraman Krishnan <sikrishn@microsoft.com> * Updated change output * Fix TSLint error * Changes to fix TSLint errors in M365Nav component * Fixed TSLint error * Created NavBase and moved common code * Fixed TSLint error: no-inferrable-types Type string trivially inferred from a string literal, remove type annotation * Position floating nav based on nav position * getStyles() implementation in M365Nav component * 1. Deleted extra change files 2. added underscore prefix to all private methods * removed M365 specifics * Moved inline styles to styles.ts
…4561) * Remove module entries. * Adding change files.
* rush generate * fix utilities * Upgrade fabric react * Rush change * Merge upstream (#2) * In Panel component, isClickableOutsideFocusTrap should not be overriden back to false if it's already set to true in focusTrapZoneProps. (#4354) * In Panel, a true value of isClickableOutsideFocusTrap prop in focusTrapZoneProps should not be overriden. * Add change file. * MessageBar: For single line, put action button before dismiss button (#4365) * Reordered button elements for single line messagebars * New example for single line with dismiss and action buttons * Added change file * [TextField, Panel] Removed componentId internal prop (#3896) * Remove componentId internal prop * change file * Reinstate prop as deprecated * Fixed tslint issue * Update magellan-componentIdInternal_2018-02-06-19-27.json * Fix errors in Signal styles (#4367) * Fix: Website: Does not show neutral quaternary colors (#4188) * Add missing quaternary and alt colors on doc page * + change file * Fix focuszone props (#4335) * Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * Fix focus zone props so that it doesn't have a typescript error * adding change file * Searchbox: deprecate defaultValue (#4225) * Deprecate SearchBox defaultValue prop. * npm run change output * Do not try to show the suggestions when input is undefined (no more exceptions in IE) (#4294) * [BasePicker] suggestions should not be shown when input does not exist * added change file * Update master_2018-03-16-09-03.json * Remove a redundant "value" prop in ComboBox multi select example to eliminate confusing behaviors. (#4366) * Add multiSelect for ComboBox * Unbreak a unit test * rush change * bug fixes * Merge from upstream and resolve local build issues * Fix merge styles * Fix pending background * Unbreak unit test cases * Fix the merge * Add controled multi-select in the example page to make sure onChanged cb works * Remove trailing white spaces * Fix bug: enter key will not trigger onChanged * Dummy change to trigger another build * refactor * Fix some minor bugs * Update some comments for ComboBox * Minor bug fixes to the example page * rush change * Delete the old rush change file * Remove a trailing space * Remove a redundant property from the ComboBox example * rush chagne * Remove old rush change file * Update stanleyy-fillin_2018-03-26-22-09.json * Moving to ts-loader, throwing on console.warn in ssr tests (#4370) * Break on warnings. * Shrinkwrap update. * Applying package updates. * Missed a reference to awesome-typescript-loader in the webpack-resources file. * Rewrite suggestions for BaseFloatingPicker (experiments) (#4273) * create new suggestions, suggestionsControl, and suggestionsStore in experiments * add change files * fix picker tests and separate scss file into two files * Update BaseFloatingPicker.tsx * remove autobind reference from bad merge * address PR comments * address PR comments, fix selection for shouldSelectFirstItem * Checkbox: text should be selectable, icon shouldn't. (#4378) * Updating checkbox select. * addin change. * Fix snapshot. * Update change output (#4380) * Contextual Menu: Revert Split Button Alignment to Previous Left Aligntment (#4369) * made spin button and base button menu option un-focusable * added spin button test * added split button contextual menu change * got rid of un-needed code * added change files * added abillitiy to not focus on primary button for split button, but only on the container * enter on focus on split button trigger primary action * added split button style for disabled * prevent opening submenu if item is disabled * tighten restrictions on opening split buttons to open with alt + down * refactored button name and fixed test * updated bundle size * changed on menu item click to bw able to take in a keyboard event * updated package json * fixed weird tabbing * changed way we structured the focus * added stop propagation * changed split button container key down to work with other buttons now * update bundle size * added correct split button container styles * removed unnecessary attribute * fixed focusing on menu button when primary button is disabled * added change to focus * added aria hidden * fixed span location and moved TODO * added support to focus on whole container in split button for contextual menus * added comment * fixed styling issues with buttons * fixed style problems for contextual split button where content is centered * reverted change * added appropriate change file * Update contextualMenuAlignSplitButton_2018-03-27-18-13.json * Integrate markdown-to-jsx in example-app-base for use in documentation (#4302) * Add markdown to jsx related packages and update shrinkwrap * Copy template components to example app base and correct imports. * Create example md files * Add Markdown typings * Remove commented code * Test using md files in Activity Item Page * Simplify raw-loader md imports * npm run change output * Expand md import to full path * Applying package updates. * Contextual Menu Fix Split Button Submenu Target (#4368) * Update SplitButton submenu in ContextualMenu to base itself of the splitButtonContainer * rush change * used ref to pass in container instead of parent element for more defenseive code * changed class to use correct refs * added example and refactored focus * Initials for phone numbers (#4376) * Adding option for calculating initials for phone numbers * Added change description * Name change and cleanup * Update initials-for-phonenumbers_2018-03-27-14-10.json * Update initials-for-phonenumbers_2018-03-27-14-10.json * Applying package updates. * Markdown-to-jsx: fix dependencies (#4389) * Add markdown to jsx related packages and update shrinkwrap * Copy template components to example app base and correct imports. * Create example md files * Add Markdown typings * Remove commented code * Test using md files in Activity Item Page * Simplify raw-loader md imports * npm run change output * Expand md import to full path * Move markdown and syntax packages to dependencies. * Move md files to docs folder. * Applying package updates. * Remove root-level imports of office-ui-fabric-react from /experiments (#4392) * Remove root imports of office-ui-fabric-react * Update change output * Fixing tests in experiments to not generate warnings in `npm start`. (#4391) * Applying package updates. * Variants: fix theming output so original input theme values are respected (#4393) * oops * changefile * dry * max line length error * Applying package updates. * OverflowSet: allow the OverflowSet to not be contained within a FocusZone (#4400) * Add a prop so that OverflowSets do not have to contain FocusZones * pull the common aspects into variables so they can be reused * simplify OverflowSet even more (use Tag to remove duplication) * Revert back and remove the key since it's no longer needed * rush change * Make sure the focusZoneProps are still getting passed down * The divProperties only need to be used when doNotContainWithinFocusZone is true * Remove unneeded import * DetailsList: link color invisible for selected row in high-contrast-white (#4395) * DetailsList: link color too close to selected background in high-contrast-white * add change file * SplitButton: Close menu when primary button is clicked (#4403) * Updating the split button to close the menu when the primary button is executed. * change * Fix Signal rendering in IE (#4404) * More Signals fixes * Update change output * Pass all props to Signal Icon elements * Update change output * Pickers: Fix suggestions not having proper value selected (#4408) * Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * fix picker suggestions and add many tests * adding snap file * adding change file * improve test * fix tests and config * revert test changes * last test update * update test name and snapshot * remove tests to expedite checkin * Breadcrumb: File rename to make the 6.0 merge diff more readable. (#4394) * File rename to make the 6.0 merge diff more readable. * Adding checkbox. * Also moving a few more. * Pickers: Add suggestions tests (#4409) * Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * fix picker suggestions and add many tests * adding snap file * adding change file * improve test * fix tests and config * revert test changes * last test update * update test name and snapshot * undo suggestions change so it will merge properly * revert change to suggestions * Disable tree shaking (temporarily) (#4410) * Temporarily disable tree shaking. * Adding change files. * HTMLButton -> HTML Element
* undo * Adding change file. * Redoing a less intrusive fix. * Adding change file. * Updating snapshot. * Revert "Updating snapshot." This reverts commit da8d1c9.
* ContextualMenu: Update mousemove to only do anything if there is not another pending mouse enter/move/leave to improve the snappiness of the updates * rush change * change spacing * Make sure we are clearing the enterTimerId after executing in the settimeout * fix missing line to set enterTimerId back to undefined if the item does not have a submenu
* Scaffold styles file * Split to base file. * Scaffold types file. * Export base
* High contrast focus and hover + regular focus fix * Added change file * In HC, highlighting text on hover, too
…f the text (#4587) * Clicks before text set cursor to beginning of text * Add change file * Fix chrome bug and add cursor * Updated snapshot
* Pulsing beacon straight from Coachmark, just smaller, needs perf impr * timing like coachmark * Only render the beacon if necessary * More consistent classname * More descriptive prop * More aligned icon positioning, ready for animation to come from styling * Added animation from styling package * Removed comma * Added change file * Updated snaphots * Added test for animation * Double pulse and single pulse * Animation polish + content fade and slide * Updated snapshot and removed unused import * Added styling change file * Add missing semicolon * Lower zIndex and fix HC mode alignment * Updated snapshot * Switch default beacon colors to theme colors * Setting default beacon colors from the theme in styling instead of default props
…4552) * Fixing invalid aria-owns field on BasePicker * Rush change log * Removing unnecessary !! * Changing blank string to undefined * Updating snapshots to use undefined as well * Fixes issue for active descendant
* Fix PersonaCoin index import * Update change output
* Update .travis.yml * Reenable bundlesize in yaml * Remove additions
* Remove unused variables * Add change file
* Fix typos * Fix minor typos
* Update createRef to match the new React api * Add changefile * Keep the .value supported through a getter. * Add test * Lint errors
* Number.isNaN does not exist in IE11 * Rush change
… for saving pending changes (#4594) * added new paramater to callback * added change file * updated the combobox type import * changed callback to include all events instead of just keycode * made events more generic so user can parse it themselves * made event optional * re-arranged function call and added more any events * removed unneeded parameter added * updated change file * fixed type * changed event to any to prevent crashes
* TextField: Implemented masking * Changed example * Change file * Moved functions to util. Added tests * Added selection deletion tests * Refactored textfield into separate components * Deleted base and default textfields * Revert additional changes * Fixed refs * Update magellan-textFieldMasking_2018-01-24-01-35.json * Added enzyme and snapshot tests for the component * Fixed typo * Added character overflow test * Undo changes to textfield * Fixed linting error * Update TextField.Basic.Example.tsx * Added comments to inputMask.ts * Removed trailing whitespace * Fix build errors for Lambert * Update jest snapshot * Fix build errors
* Flex shrink * Change file.
* added linkNativeProps prop to PivotItem to pass to the link/CommandButton element * rush change * updated to headerButtonProps and deprecated linkText while adding headerText * better implementation of headerText * fixed name attribute
…edby and aria-describedby like Dialog (#4626) * enable native props * update documentation * rush change
* add onRenderDescription to TextField * delete empty change files * fix linting error * use arrow function instead of autobind * address pr feedback * allow onRenderDescriptiont to be invoked in absence of description * remove autobind
* Add typedefs * More typedefs * More typdefs * Fix merge mistake * Fix conflict * Typedef wip * More typedefs * Fixup oufr typedefs * Fix experiments * Add missing import of type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
(give an overview)
Focus areas to test
(optional)