Skip to content

ProgressIndicator: convert to mergeStyles - part 1 #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jordandrako merged 4 commits into from
Apr 18, 2018
Merged

ProgressIndicator: convert to mergeStyles - part 1 #4592

jordandrako merged 4 commits into from
Apr 18, 2018

Conversation

@jordandrako
Copy link
Contributor

@jordandrako jordandrako commented Apr 17, 2018 •
edited
Loading

Pull request checklist

  • Include a change request file using $ npm run change

Description of changes

  • Create styles file.
  • Split ProgressIndicator into styled and base file
  • Create/expand interfaces

@jordandrako jordandrako mentioned this pull request Apr 18, 2018
Merged
4 tasks
oengusmacinog-zz
oengusmacinog-zz approved these changes Apr 18, 2018
View reviewed changes
Copy link
Collaborator

@oengusmacinog-zz oengusmacinog-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jordandrako jordandrako merged commit 1b45279 into microsoft:master Apr 18, 2018
@KevinTCoughlin KevinTCoughlin mentioned this pull request May 7, 2018
Merged
1 task
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mikewheaton mikewheaton Awaiting requested review from mikewheaton

1 more reviewer

@oengusmacinog-zz oengusmacinog-zz oengusmacinog-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jordandrako @oengusmacinog-zz