Propagate onRenderInitials correctly from Persona to PersonaCoin#4631
Merged
Markionium merged 4 commits intomicrosoft:masterfrom Apr 20, 2018
ivdijan:ivdijan/onRenderInitials
Merged
Propagate onRenderInitials correctly from Persona to PersonaCoin#4631Markionium merged 4 commits intomicrosoft:masterfrom ivdijan:ivdijan/onRenderInitials
Markionium merged 4 commits intomicrosoft:masterfrom
ivdijan:ivdijan/onRenderInitials
Conversation
Merge upstream master
Merge upstream master
mtennoe
approved these changes
Apr 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Persona component takes onRenderInitials property and needs to pass it down to PersonaCoin. Without that part, the render override doesn't function.
Focus areas to test
(optional)