Shimmer: fixing casing on enums#4542
Conversation
| } | ||
|
|
||
| export const enum ShimmerElementVerticalAlign { | ||
| CENTER = 'center', |
There was a problem hiding this comment.
CENTER [](start = 2, length = 6)
I am a bit confused. Why would we have two groups of enums ?
There was a problem hiding this comment.
@manishgarg1 The old ones are left until changes will be released and experiments package version will get bumped in odsp-common where ShimmerElementType.LINE is used in FileHoverCard. When that will be updated I will remove them from here.
There was a problem hiding this comment.
Got it. In that case I would recommend putting a comment like this. "@deprecated - The CAPS lock values will be deprecated soon"
There was a problem hiding this comment.
I thought about doing this, but I don't know if it makes sense as I know the only place outside the Fabric it has been used where it could break the contract with the component.
The component is still in experiments package and is if somebody put it into production code they were warned that it might brake due to API changes. So because I know were it is used in odsp-common I will just replace them in there and right after will remove them in here.
There was a problem hiding this comment.
Where would be the right place to put @deprecated?
|
@dzearing Good to merge? |
|
Looks straightforward to me hence merging. |
2 participants
Pull request checklist
$ npm run changeDescription of changes
Fixing casing on enums.