Bring back isResultsFooterVisible that is props but never used#4548
Merged
joschect merged 5 commits intomicrosoft:masterfrom Apr 13, 2018
jozhan:hide_suggestions_footer
Merged
Bring back isResultsFooterVisible that is props but never used#4548joschect merged 5 commits intomicrosoft:masterfrom jozhan:hide_suggestions_footer
joschect merged 5 commits intomicrosoft:masterfrom
jozhan:hide_suggestions_footer
Conversation
joschect
reviewed
Apr 13, 2018
| !moreSuggestionsAvailable && !isMostRecentlyUsedVisible && !isSearching ? | ||
| isResultsFooterVisible !== false && !moreSuggestionsAvailable && !isMostRecentlyUsedVisible && !isSearching ? | ||
| (<div className={ css('ms-Suggestions-title', styles.suggestionsTitle) }> | ||
| { footerTitle && footerTitle(this.props) } |
Contributor
There was a problem hiding this comment.
It looks like this is already tied to the footer generation on line 128. I'd add isResultsFooterVisible to there and add footerTitle to the check down here.
Contributor
Author
There was a problem hiding this comment.
@joschect makes sense. Test needs to be updated since if nothing is specified, the footer div will not be rendered. And it shouldn't be anyways.
joschect
reviewed
Apr 13, 2018
| resultsMaximumNumber, | ||
| resultsFooterFull, | ||
| resultsFooter, | ||
| isResultsFooterVisible, |
Contributor
There was a problem hiding this comment.
move this to the bottom and set it to true. It will look like
let {
<other props>
suggestionsHeaderText,
isResultsFooterVisible = true
} = this.props;
joschect
approved these changes
Apr 13, 2018
joschect
reviewed
Apr 13, 2018
| onSuggestionRemove?: (ev?: React.MouseEvent<HTMLElement>, item?: IPersonaProps, index?: number) => void; | ||
| /** | ||
| * Indicates if the text in resultsFooter or resultsFooterFull should be shown at the end of the suggestion list. | ||
| * It defaults to true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Footer element has a default style which makes it difficult to hide (will still see border lines with no content) unless make css change on its ms- style. There is a prop isResultsFooterVisible but was never used and I am bringing it back.
Focus areas to test
(optional)