FocusZone: undoing a change which caused a regression#4559
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Apr 15, 2018
dzearing:undo-focuszone-change
Merged
FocusZone: undoing a change which caused a regression#4559dzearing merged 2 commits intomicrosoft:masterfrom dzearing:undo-focuszone-change
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:undo-focuszone-change
Conversation
manishgarg1
approved these changes
Apr 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a FocusZone regression that was introduced by the fix for #4488.
Say you have some dom structure like:
I am seeing that clicking on the
spancauses theFocusZone::onClickmethod to be called wheretargetis thespan. This causes FocusZone to track thespan, and not thebutton, as the active element, causingtabIndexon the span to be set to -1, which in turn causes side-effects such as making the span focusable with a mouse and creating visual focus rects on the wrong things.Undoing the change that introduced this. The original intention of the fix was to reset alignment only when you click on a focusable element. This needs more special consideration and a less intrusive fix.