Skip to content

FocusZone: undoing a change which caused a regression#4559

Merged
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:undo-focuszone-change
Apr 15, 2018
Merged

FocusZone: undoing a change which caused a regression#4559
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:undo-focuszone-change

Conversation

@dzearing
Copy link
Copy Markdown
Member

Found a FocusZone regression that was introduced by the fix for #4488.

Say you have some dom structure like:

<FocusZone>
  <button>
    <span>Area</span>
  </button>
</FocusZone>

I am seeing that clicking on the span causes the FocusZone::onClick method to be called where target is the span. This causes FocusZone to track the span, and not the button, as the active element, causing tabIndex on the span to be set to -1, which in turn causes side-effects such as making the span focusable with a mouse and creating visual focus rects on the wrong things.

Undoing the change that introduced this. The original intention of the fix was to reset alignment only when you click on a focusable element. This needs more special consideration and a less intrusive fix.

@dzearing dzearing merged commit c3d5683 into microsoft:master Apr 15, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants