Choicegroup: Improved states for focus, HC focus, HC hover#4572
Merged
lynamemi merged 3 commits intomicrosoft:masterfrom Apr 18, 2018
Merged
Choicegroup: Improved states for focus, HC focus, HC hover#4572lynamemi merged 3 commits intomicrosoft:masterfrom
lynamemi merged 3 commits intomicrosoft:masterfrom
Conversation
Member
|
What's the one with the simple radio buttons? Which has hover? |
Collaborator
Author
|
@betrue-final-final, the top one has hover. Yellow is the resting state. |
Collaborator
|
Looks good to me. @betrue-final-final ? |
manishgarg1
approved these changes
Apr 17, 2018
Member
|
The top choice is a hover, or is hover over the dropdown? If it's the radio, I'm confused. Let's chat quick tomorrow AM. |
betrue-final-final
approved these changes
Apr 18, 2018
srideshpande
approved these changes
Apr 18, 2018
Contributor
srideshpande
left a comment
srideshpande
left a comment
There was a problem hiding this comment.
Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Focus + Hover (with image / icon):
Focus:
Hover:
HC Focus + Hover:
HC Focus:
Focus areas to test
(optional)