Prevent SelectionZone from interfering with nested links and buttons#4544
Merged
ThomasMichon merged 3 commits intomicrosoft:masterfrom Apr 15, 2018
Merged
Prevent SelectionZone from interfering with nested links and buttons#4544ThomasMichon merged 3 commits intomicrosoft:masterfrom
ThomasMichon merged 3 commits intomicrosoft:masterfrom
Conversation
ecraig12345
approved these changes
Apr 13, 2018
Member
ecraig12345
left a comment
There was a problem hiding this comment.
Looks good to me, but you should probably also have someone more familiar with this code/selection-related issues take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Right now, if the user clicks an
<a>or<button>within a selectable item in a<SelectionZone>, the selection logic still executes, so the underlying item becomes selected before the default behavior of the child element gets to execute. This can be a problem if changing the selection state reconfigures the elements, or the modal state blocks the next UX events from firing.To fix this,
SelectionZoneshould not interceptmouseDownorclickevents dispatched to a child<a>,<button>, or<input>element, unless that element hasdata-selection-invokeordata-selection-toggleapplied.