Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
3ab70bd
SpinButton: Keep arrow keys inside spin button (#4529)
jspurlin Apr 12, 2018
0e2e8bd
Addressing Issue #4386 - Dropdown cannot be invoked as per instructio…
oengusmacinog-zz Apr 12, 2018
0803ee2
start aria-rowindex from 1 instead of 0 (#4515)
mutn3ja Apr 12, 2018
be86d92
Fix style and alignment issues in the DetailsList header (#4487)
ThomasMichon Apr 12, 2018
7a5e2c3
Prefer const for ExtendedPicker, FloatingPicker, and SelectedItemsLis…
amyngu Apr 12, 2018
1bf72b3
Update package.json
dzearing Apr 13, 2018
944bee5
Ddlbrena/popup scroll bar fix (#4528)
ddlbrena Apr 13, 2018
8ef07e5
ComboBox: Option to use ariaLabel prop as preview text (#4540)
kysedate Apr 13, 2018
547c418
Addressing Issue #3385 - [Picker][TagPicker][Accessibilty] TagPicker …
oengusmacinog-zz Apr 13, 2018
6d4cfa6
Fix Bug #4525: ColorPicker does not update upon text field changes wh…
wutonghao Apr 13, 2018
589eb52
ComboBox: Option rendering optimization (#4527)
kysedate Apr 13, 2018
ebbb573
ComponentPage: Add Edit On GitHub buttons to page sections (#4424)
jordandrako Apr 13, 2018
40b585d
Add ability to use Customizer to control the default layer host (#4518)
ThomasMichon Apr 13, 2018
4ea06e5
ContextualMenu: Improve perf and allow buttons to benefit. (#4524)
joschect Apr 13, 2018
a1d92a6
Shimmer: fixing casing on enums (#4542)
Vitalius1 Apr 13, 2018
7069325
Add focus method to Breadcrumb (#4537)
Hugodol Apr 13, 2018
5a67c36
Shimmer: fixing import statements (#4541)
Vitalius1 Apr 13, 2018
73c781f
Fix create-component script to build successfully and documentation t…
aditima Apr 13, 2018
e924e27
Add focus method to Pivot (#4536)
Hugodol Apr 13, 2018
0e488ca
Addressing Issue #4305 - Input multiline inside Panel doesn't compati…
oengusmacinog-zz Apr 13, 2018
836bfff
Bring back isResultsFooterVisible that is props but never used (#4548)
jozhan Apr 13, 2018
51e5f23
Contextual Split Button: Change styling to only have one split button…
chang47 Apr 13, 2018
9c8ccb3
make it possible to block hover card in some special case, for exampl…
chaofeng2014 Apr 13, 2018
acc2c4b
Prevent SelectionZone from interfering with nested links and buttons …
ThomasMichon Apr 15, 2018
7c9c5c6
Experiments: adding two more example to shimmer (#4555)
Vitalius1 Apr 15, 2018
c3d5683
FocusZone: undoing a change which caused a regression (#4559)
dzearing Apr 15, 2018
d6f161b
Nav experiment added (#4405)
sikrishn Apr 15, 2018
4b856fc
Remove module entries to avoid duplicate modules in webpack bundles. …
dzearing Apr 15, 2018
a79de6b
Upgrade to TypeScript 2.8.1 (#4411)
christiango Apr 15, 2018
1e2afca
FocusZone: redo the mouse down change to reset alignment (#4560)
dzearing Apr 16, 2018
c38b371
Experiments package: fixing imports in example pages. (#4554)
Vitalius1 Apr 16, 2018
6f8a180
Update react to 16.3.1, updating typings, fixing errors. (#4562)
dzearing Apr 16, 2018
3628c32
Documentcardtitle title tests (#4452)
Markionium Apr 16, 2018
0c830b2
Fabric component: logic moved to helpers in utilities. (#4426)
dzearing Apr 16, 2018
526f93d
Applying package updates.
Apr 16, 2018
68d99e2
Adding scss temp files to the clean script to avoid surprises when sy…
dzearing Apr 16, 2018
5ab4612
Fix for onMenuClick firing on every keyDown (#4557)
Markionium Apr 16, 2018
98c5903
Applying package updates.
Apr 16, 2018
68acb9b
mergeStyles: asynchronously reset the next style element being used (…
dzearing Apr 17, 2018
3c5e9c9
Fixing build. (#4579)
dzearing Apr 17, 2018
8829b1f
Website: Make titles on GetStarted page clickable (#4570)
lynamemi Apr 17, 2018
5867a69
Disable bundlesize in Travis workflow to unblock PRs.
dzearing Apr 17, 2018
4dc9071
Fix improper imports from index files (#4585)
ThomasMichon Apr 17, 2018
7ed1f9d
Mark Panel content as scrollable (#4577)
ThomasMichon Apr 17, 2018
b6c7ac2
Applying package updates.
Apr 17, 2018
4efff92
Docs: Convert document Overviews and Best Practices to markdown (#4512)
jordandrako Apr 17, 2018
7dabb13
Experiments: fix bad imports (#4580)
Vitalius1 Apr 17, 2018
9e838b8
Invoke CommandBar's onItemClick vs item onClick when item has an href…
KevinTCoughlin Apr 17, 2018
e176966
Applying package updates.
Apr 18, 2018
9cc47f5
ContextualMenu: Update mousemove behavior (#4589)
jspurlin Apr 18, 2018
1b45279
ProgressIndicator: convert to mergeStyles - part 1 (#4592)
jordandrako Apr 18, 2018
c49c51c
Applying package updates.
Apr 18, 2018
7c592e9
Choicegroup: Improved states for focus, HC focus, HC hover (#4572)
lynamemi Apr 18, 2018
5f6ae67
Searchbox: Clicking in front of input text puts cursor at the start o…
lynamemi Apr 18, 2018
7d06629
ActivityItem: add pulsing beacon animation (#4553)
lynamemi Apr 18, 2018
9686b87
Fixes invalid aria-owns/ activedescendant attributes on BasePicker (#…
rfballantyne Apr 18, 2018
dfc9c2c
Fix more index imports (#4604)
ThomasMichon Apr 18, 2018
9a47213
Reenable bundlesize in yaml (#4590)
erichdev Apr 18, 2018
5610079
Applying package updates.
Apr 19, 2018
775e1f5
Add optional overflowIndex prop to Breadcrumb (#4609)
samuelmtimbo Apr 19, 2018
5954ea4
Remove unused variables and enable no-unused-variable (#4608)
Markionium Apr 19, 2018
6c70a9e
Fix minor typos (#4607)
cliffkoh Apr 19, 2018
88c0a7c
Update Breadcrumb.base.tsx
dzearing Apr 19, 2018
e77a31b
Update createRef to match the new React 16.3 api (#4598)
Markionium Apr 19, 2018
c86fc5b
Remove usage of Number.NaN (#4615)
christiango Apr 19, 2018
02b098f
ComboBox: Add any event as additional parameter to onChanged callback…
chang47 Apr 19, 2018
88a6620
Applying package updates.
Apr 19, 2018
bd2e7b1
[TextField] Implemented masking (#3783)
lambertwang Apr 19, 2018
b6c5fde
DetailsRow: Flexshrink fix (#4622)
dzearing Apr 19, 2018
ef0cfe4
Revert unintended changes in Dropdown from #4512 (#4625)
jordandrako Apr 20, 2018
365de61
Remove tslint ignore of React (#4614)
Markionium Apr 20, 2018
f2dc9cb
Addressing Issue #4349 - Data attributes on Pivot Item (#4461)
oengusmacinog-zz Apr 20, 2018
ffd046e
Addressing Issue #3634 - Accessibility: Panel should have aria-labell…
oengusmacinog-zz Apr 20, 2018
5cab1cf
add onRenderDescription to TextField (#4588)
chrismohr Apr 20, 2018
9c95e9b
Typedef tslint rule fixes (ready to merge) (#4573)
Markionium Apr 20, 2018
0496c5f
Applying package updates.
Apr 20, 2018
1c60fae
Propagate onRenderInitials correctly from Persona to PersonaCoin (#4…
ivdijan Apr 20, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
57 changes: 56 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ OverflowSet/ @micahgodbolt
# Overlay/
# Panel/
# Persona/
Persona/PersonaCoin.tsx @mtennoe @jakob101
Persona/PersonaCoin/ @mtennoe @jakob101
Persona/PersonaConsts.tsx @mtennoe @jakob101
pickers/ @joschect
# Pivot/
Expand All @@ -105,4 +105,59 @@ TeachingBubble/ @micahgodbolt
Toggle/ @phkuo
Tooltip/ @micahgodbolt

## Docs
# ActivityItem/docs/
# Breadcrumb/docs/
# Button/docs/
Calendar/docs/ @lorejoh12 @sathi23
Callout/docs/ @joschect
# Check/docs/
# Checkbox/docs/
ChoiceGroup/docs/ @srideshpande
# ColorPicker/docs/
# ComboBox/docs/
CommandBar/docs/ @micahgodbolt
ContextualMenu/docs/ @joschect
DatePicker/docs/ @lorejoh12 @sathi23
# DetailsList/docs/
# Dialog/docs/
DocumentCard/docs/ @yiminwu @mikewheaton
# Dropdown/docs/
# Fabric/docs/
# FacePile/docs/
# FocusTrapZone/docs/
# FocusZone/docs/
GroupedList/docs/ @aditima
HoverCard/docs/ @atneik @Jahnp
# Icon/docs/
# Image/docs/
# Label/docs/
Layer/docs/ @ThomasMichon
# Link/docs/
List/docs/ @cschleiden
# MarqueeSelection/docs/
# MessageBar/docs/
# Modal/docs/
# Nav/docs/
OverflowSet/docs/ @micahgodbolt
# Overlay/docs/
# Panel/docs/
# Persona/docs/
pickers/docs/ @joschect
# Pivot/docs/
# Popup/docs/
# ProgressIndicator/docs/
Rating/docs/ @cschleiden
ResizeGroup/docs/ @micahgodbolt
# SearchBox/docs/
# Slider/docs/
# SpinButton/docs/
# Spinner/docs/
# SwatchColorPicker/docs/
TeachingBubble/docs/ @micahgodbolt
# TextField/docs/
# Theme/docs/
Toggle/docs/ @phkuo
Tooltip/docs/ @micahgodbolt


2 changes: 1 addition & 1 deletion .npm-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2.x
5.6.0
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ script:
fi
- npm run buildfast
- npm run bundlesize
- npm run vrtest
- npm run vrtest
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ In Jest:

For advanced usage including info about module vs. path-based imports, using an AMD bundler like Require, and deployment features, see our [advanced documentation](./ghdocs/BestPractices/Advanced.md).

## Contribute to Office UI Fabric React
## Contribute to Fabric React

Please take a look at our [contribution guidelines](./ghdocs/Contributing/Contributing.md) for more info. Also read [Contribute Bug fixes](./ghdocs/Contributing/BugFixes.md) and [Contribute New component](./ghdocs/Contributing/NewComponent.md).

Expand Down
38 changes: 38 additions & 0 deletions apps/fabric-website/CHANGELOG.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,44 @@
{
"name": "@uifabric/fabric-website",
"entries": [
{
"version": "5.7.0",
"tag": "@uifabric/fabric-website_v5.7.0",
"date": "Tue, 17 Apr 2018 18:47:11 GMT",
"comments": {
"minor": [
{
"author": "lynamemi <lynam.emily@gmail.com>",
"commit": "8829b1fde1bbe2e6920b5e619727835184a15b45",
"comment": "GetStarted page: Give titles links to their corresponding pages."
}
],
"dependency": [
{
"comment": "Updating dependency \"office-ui-fabric-react\" from `>=5.82.1 <6.0.0` to `>=5.82.2 <6.0.0`"
}
]
}
},
{
"version": "5.6.1",
"tag": "@uifabric/fabric-website_v5.6.1",
"date": "Mon, 16 Apr 2018 10:23:26 GMT",
"comments": {
"patch": [
{
"author": "David Zearing <dzearing@microsoft.com>",
"commit": "6f8a180ae2ecca66d09be97e48e8e03cc17d4d9e",
"comment": "Updating build to React 16.3.1."
}
],
"dependency": [
{
"comment": "Updating dependency \"office-ui-fabric-react\" from `>=5.81.1 <6.0.0` to `>=5.82.0 <6.0.0`"
}
]
}
},
{
"version": "5.6.0",
"tag": "@uifabric/fabric-website_v5.6.0",
Expand Down
16 changes: 15 additions & 1 deletion apps/fabric-website/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
# Change Log - @uifabric/fabric-website

This log was last generated on Thu, 05 Apr 2018 10:15:39 GMT and should not be manually modified.
This log was last generated on Tue, 17 Apr 2018 18:47:11 GMT and should not be manually modified.

## 5.7.0
Tue, 17 Apr 2018 18:47:11 GMT

### Minor changes

- GetStarted page: Give titles links to their corresponding pages.

## 5.6.1
Mon, 16 Apr 2018 10:23:26 GMT

### Patches

- Updating build to React 16.3.1.

## 5.6.0
Thu, 05 Apr 2018 10:15:39 GMT
Expand Down
4 changes: 2 additions & 2 deletions apps/fabric-website/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
}

var scripts = [
'//cdnjs.cloudflare.com/ajax/libs/react/16.2.0/umd/react.production.min.js',
'//cdnjs.cloudflare.com/ajax/libs/react-dom/16.2.0/umd/react-dom.production.min.js',
'//cdnjs.cloudflare.com/ajax/libs/react/16.3.1/umd/react.production.min.js',
'//cdnjs.cloudflare.com/ajax/libs/react-dom/16.3.1/umd/react-dom.production.min.js',
'/fabric-sitev5.js'
];

Expand Down
12 changes: 6 additions & 6 deletions apps/fabric-website/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@uifabric/fabric-website",
"version": "5.6.0",
"version": "5.7.0",
"description": "Reusable React components for building experiences for Office 365.",
"main": "lib/index.js",
"typings": "lib/index.d.ts",
Expand All @@ -22,24 +22,24 @@
"@types/node": "8.0.26",
"@types/prop-types": "15.5.2",
"@types/resemblejs": "~1.3.28",
"@types/react": "16.0.25",
"@types/react-dom": "16.0.3",
"@types/react": "16.3.10",
"@types/react-dom": "16.0.5",
"@types/webpack-env": "1.13.0",
"es6-promise": "^4.1.0",
"es6-weak-map": "^2.0.2",
"highlight.js": "^9.12.0",
"office-ui-fabric-core": ">=9.0.0 <10.0.0",
"office-ui-fabric-react-tslint": ">=5.0.0 <6.0.0",
"react": "^16.2.0",
"react-dom": "^16.2.0",
"react": "^16.3.1",
"react-dom": "^16.3.1",
"react-highlight": "^0.10.0",
"write-file-webpack-plugin": "^4.1.0"
},
"dependencies": {
"@microsoft/load-themed-styles": "^1.7.13",
"color-functions": "1.1.0",
"json-loader": "^0.5.7",
"office-ui-fabric-react": ">=5.81.1 <6.0.0",
"office-ui-fabric-react": ">=5.85.0 <6.0.0",
"tslib": "^1.7.1"
}
}
6 changes: 3 additions & 3 deletions apps/fabric-website/src/components/App/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,20 @@ export class App extends React.Component<IAppProps, any> {
};
}

public componentDidMount() {
public componentDidMount(): void {
window.addEventListener('scroll', this._handleNavPositioning);
window.addEventListener('resize', this._handleNavPositioning);

this._attachedScrollThreshold = AttachedScrollUtility.calculateAttachedScrollThreshold();
this._handleNavPositioning();
}

public componentWillUnmount() {
public componentWillUnmount(): void {
window.removeEventListener('scroll', this._handleNavPositioning);
window.removeEventListener('resize', this._handleNavPositioning);
}

public render() {
public render(): JSX.Element {
let { navHeight } = this.state;
let navPosition: 'fixed' | 'absolute' = this.state.isAttached ? 'fixed' : 'absolute';
let navStyle = {
Expand Down
2 changes: 1 addition & 1 deletion apps/fabric-website/src/components/CodeBlock/CodeBlock.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class CodeBlock extends React.Component<ICodeBlockProps, ICodeBlockState>
this._onToggleClicked = this._onToggleClicked.bind(this);
}

public render() {
public render(): JSX.Element {
let { language, isCollapsible, isLightTheme, children } = this.props;
let { isOpen } = this.state;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface IColorTableState {
}

export class ColorTable extends React.Component<IColorTableProps, IColorTableState> {
public render() {
public render(): JSX.Element {
let { content } = this.props;

return (
Expand Down
2 changes: 1 addition & 1 deletion apps/fabric-website/src/components/DOIcon/DOIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class DOIcon extends React.Component<IDOIconProps, {}> {
ariaHidden: true
};

public render() {
public render(): JSX.Element {
return (
<i
className={ 'od-Icon od-Icon--' + this.props.iconClass + ' ms-bgColor-' + this.props.bgColor }
Expand Down
20 changes: 10 additions & 10 deletions apps/fabric-website/src/components/DONavigation/DONavigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
private headerel;
private navcontainerel;

public componentDidMount() {
public componentDidMount(): void {
let currentButton;
let submenu;
let currentContainer;
Expand Down Expand Up @@ -76,7 +76,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
this._processResize();
}

public render() {
public render(): JSX.Element {
return (
<div className='od-Navigation'>
<div className='od-Navigation-searchContainer'>
Expand Down Expand Up @@ -174,7 +174,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
return linkElements;
}

private _mouseMoveHandler(e) {
private _mouseMoveHandler(e): void {
let linkContainer = document.querySelector(this.OPEN_LINK_CONTAINER);
let subMenuContainer;
let targetHeight;
Expand Down Expand Up @@ -240,7 +240,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _processHamburger(e, isKeyEvent?: boolean) {
private _processHamburger(e, isKeyEvent?: boolean): void {
let linkEL: HTMLElement;
if (!this.hbuttonel.classList.contains(this.HAMBURGER_OPEN_STATE)) {
this.hbuttonel.classList.add(this.HAMBURGER_OPEN_STATE);
Expand All @@ -256,7 +256,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _closeDropdownHandler(e) {
private _closeDropdownHandler(e): void {
if (!this._isDescendant(this.headerel, document.activeElement)) {
this._removeDropdown();
}
Expand All @@ -278,7 +278,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _hamburgerHandler(e: any) {
private _hamburgerHandler(e: any): void {
if (e.keyCode) {
if (e.keyCode === 13) {
this._processHamburger(e, true);
Expand All @@ -290,7 +290,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _processMenuToggle(e) {
private _processMenuToggle(e): void {
let ancestor;
if (e.target.classList.contains(this.CONTAINER_CLASS)) {

Expand All @@ -316,7 +316,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _toggleMenuHandler(e) {
private _toggleMenuHandler(e): void {
if (e.keyCode) {
if (e.keyCode === 13) {
this._processMenuToggle(e);
Expand All @@ -328,7 +328,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _isDescendant(parent, child) {
private _isDescendant(parent, child): boolean {
let node = child.parentNode;
while (node) {
if (node === parent) {
Expand All @@ -345,7 +345,7 @@ export class DONavigation extends React.Component<IDONavigationProps, IDONavigat
}
}

private _findAncestor(el, cls) {
private _findAncestor(el, cls): void {
let newCLS = cls.replace('.', '');
let newEL = el;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ export interface IDONavigationLinkState {
}

export class DONavigationLink extends React.Component<IDONavigationLinkProps, IDONavigationLinkState> {
public static defaultProps = {
role: 'menuitem'
};
public static defaultProps = {
role: 'menuitem'
};

public render() {
return (
<a className='od-Navigation-subMenuItem' href={ this.props.href } role={ this.props.role }>
{ this._getIcon() }
{ this.props.label }
</a>
);
}
public render(): JSX.Element {
return (
<a className='od-Navigation-subMenuItem' href={ this.props.href } role={ this.props.role }>
{ this._getIcon() }
{ this.props.label }
</a>
);
}

private _getIcon() {
if (this.props.icon) {
return <DOIcon iconClass={ this.props.icon.iconClass } bgColor={ this.props.icon.bgColor } />;
}
private _getIcon() {
if (this.props.icon) {
return <DOIcon iconClass={ this.props.icon.iconClass } bgColor={ this.props.icon.bgColor } />;
}
}
}
Loading