Fix style and alignment issues in the DetailsList header#4487
Merged
aditima merged 5 commits intomicrosoft:masterfrom Apr 12, 2018
Merged
Fix style and alignment issues in the DetailsList header#4487aditima merged 5 commits intomicrosoft:masterfrom
aditima merged 5 commits intomicrosoft:masterfrom
Conversation
dzearing
approved these changes
Apr 10, 2018
Member
dzearing
left a comment
There was a problem hiding this comment.
@cschleiden just making sure you're aware here.
Member
|
@aditima If you're good with this can you merge? |
Member
Author
|
I mostly was holding this open in case there was an objection to adding a couple more theme color slots. |
aditima
approved these changes
Apr 12, 2018
|
@ThomasMichon this change causes the contextMenu handler hit area to shrink down to just the text span (.cellTitle). For example, if the list contains a column whose name is 'Id' and the column is wide, the context menu on the column header can only be triggered if the user right click on the text 'id', not the whole width of the column header. This is different from v5.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change fixes a couple long-standing issue with
DetailsHeader:display: inline-flexand made the name truncate in favor of the status indicator.aria-describedbyattribute if there is no attempt to provide a tooltip implementation for the header cells.