Skip to content

Fix style and alignment issues in the DetailsList header#4487

Merged
aditima merged 5 commits intomicrosoft:masterfrom
ThomasMichon:details-header
Apr 12, 2018
Merged

Fix style and alignment issues in the DetailsList header#4487
aditima merged 5 commits intomicrosoft:masterfrom
ThomasMichon:details-header

Conversation

@ThomasMichon
Copy link
Copy Markdown
Member

Overview

This change fixes a couple long-standing issue with DetailsHeader:

  • The header cells are missing hover styles. Added theme slots for the hover styles and made them match standard colors.
  • If a header cell is narrow, then the status icon (sorted, grouped, etc) overflows the width, causing visual artifacts. Changed the cell title box to use display: inline-flex and made the name truncate in favor of the status indicator.
  • Removed the phantom aria-describedby attribute if there is no attempt to provide a tooltip implementation for the header cells.

Copy link
Copy Markdown
Member

@dzearing dzearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschleiden just making sure you're aware here.

@dzearing
Copy link
Copy Markdown
Member

@aditima If you're good with this can you merge?

Copy link
Copy Markdown
Collaborator

@manishgarg1 manishgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ThomasMichon
Copy link
Copy Markdown
Member Author

I mostly was holding this open in case there was an objection to adding a couple more theme color slots.

@hailiu2586
Copy link
Copy Markdown

@ThomasMichon this change causes the contextMenu handler hit area to shrink down to just the text span (.cellTitle). For example, if the list contains a column whose name is 'Id' and the column is wide, the context menu on the column header can only be triggered if the user right click on the text 'id', not the whole width of the column header. This is different from v5.x

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants