start aria-rowindex from 1 instead of 0#4515
Merged
aditima merged 3 commits intomicrosoft:masterfrom Apr 12, 2018
mutn3ja:users/prmutn/ariaRowIndexBugfix
Merged
start aria-rowindex from 1 instead of 0#4515aditima merged 3 commits intomicrosoft:masterfrom mutn3ja:users/prmutn/ariaRowIndexBugfix
aditima merged 3 commits intomicrosoft:masterfrom
mutn3ja:users/prmutn/ariaRowIndexBugfix
Conversation
mutn3ja
changed the title
add newline at end
manishgarg1
approved these changes
Apr 12, 2018
Collaborator
|
Looks good to me, but I would let @aditima also comment. She is the owner of the DetailsList component. |
aditima
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
As mentioned here,
aria-rowindexshould start from 1.Issue details
Firefox with NVDA cannot doesn't read the row number position properly. See attached gif
