Remove usage of Number.NaN #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffkoh
suggested changes
Apr 19, 2018
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Remove usage of Number.isNaN from SpinButton.tsx since it doesn't exist in IE11", |
Contributor
There was a problem hiding this comment.
SpinButton: Handle the case where Number.isNaN is not supported in IE 11
| aria-labelledby={ label && this._labelId } | ||
| aria-valuenow={ !Number.isNaN(Number(value)) ? Number(value) : undefined } | ||
| aria-valuetext={ Number.isNaN(Number(value)) ? value : undefined } | ||
| aria-valuenow={ !isNaN(Number(value)) ? Number(value) : undefined } |
Contributor
There was a problem hiding this comment.
It would be more robust to check if Number.isNaN is a defined function and if so, to use it rather than rely on the less reliable, global isNaN function all the time.
Contributor
There was a problem hiding this comment.
@cliffkoh, this is the only usage of Number.isNaN that I could find in fabric, everywhere else uses isNaN
jspurlin
approved these changes
Apr 19, 2018
dzearing
approved these changes
Apr 19, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 19, 2018
* master: Applying package updates. ComboBox: Add any event as additional parameter to onChanged callback for saving pending changes (microsoft#4594) Remove usage of Number.NaN (microsoft#4615) Update createRef to match the new React 16.3 api (microsoft#4598) Update Breadcrumb.base.tsx Fix minor typos (microsoft#4607) Remove unused variables and enable no-unused-variable (microsoft#4608) Add optional overflowIndex prop to Breadcrumb (microsoft#4609) Applying package updates. Reenable bundlesize in yaml (microsoft#4590) Fix more index imports (microsoft#4604)
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Apr 20, 2018
* master: DetailsRow: Flexshrink fix (microsoft#4622) [TextField] Implemented masking (microsoft#3783) Applying package updates. ComboBox: Add any event as additional parameter to onChanged callback for saving pending changes (microsoft#4594) Remove usage of Number.NaN (microsoft#4615)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
SpinButton.tsx is not compatible with IE11 due to the usage of Number.isNaN, which is not supported in IE: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN
In this case isNaN should be sufficient for our needs, so updating the code to use that.