Skip to content

Add focus method to Pivot#4536

Merged
manishgarg1 merged 4 commits intomicrosoft:masterfrom
Hugodol:pivotFocus
Apr 13, 2018
Merged

Add focus method to Pivot#4536
manishgarg1 merged 4 commits intomicrosoft:masterfrom
Hugodol:pivotFocus

Conversation

@Hugodol
Copy link
Copy Markdown
Contributor

@Hugodol Hugodol commented Apr 12, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • [ x] Include a change request file using $ npm run change

Description of changes

Add a focus method to the Pivot.

Focus areas to test

(optional)

@manishgarg1 manishgarg1 self-assigned this Apr 13, 2018
@manishgarg1
Copy link
Copy Markdown
Collaborator

Hi @Hugodol , Can you please take a look at the patter in BaseExtendedPicker.tsx. That seems cleaner.

@manishgarg1
Copy link
Copy Markdown
Collaborator

Thanx @Hugodol for taking the feedback. Looks good to me. @dzearing, any objections?

@manishgarg1 manishgarg1 assigned dzearing and unassigned manishgarg1 Apr 13, 2018
private _keyToTabIds: { [key: string]: string };
private _pivotId: string;

protected focusZone = createRef<FocusZone>();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private

@manishgarg1 manishgarg1 merged commit e924e27 into microsoft:master Apr 13, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants