FocusZone: redo the mouse down change to reset alignment#4560
Merged
dzearing merged 7 commits intomicrosoft:masterfrom Apr 16, 2018
dzearing:redo-focuszone-change
Merged
FocusZone: redo the mouse down change to reset alignment#4560dzearing merged 7 commits intomicrosoft:masterfrom dzearing:redo-focuszone-change
dzearing merged 7 commits intomicrosoft:masterfrom
dzearing:redo-focuszone-change
Conversation
This reverts commit da8d1c9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
When the
mouseDownevent is received byFocusZone, focus alignment is reset (which is used in bidirectional up/down calculations.Focus areas to test
You have a grid of items:
A B
C D
Focus is on A initially
Before:
Left arrow to B, press down. Goes to D.
Click on A, press down. Goes to D. (BAD!)
After:
Left arrow to B, press down. Goes to D.
Click on A, press down. Goes to C. (GOOD!)