Merged
Conversation
* Updating the split button to close the menu when the primary button is executed. * change
* More Signals fixes * Update change output * Pass all props to Signal Icon elements * Update change output
* Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * fix picker suggestions and add many tests * adding snap file * adding change file * improve test * fix tests and config * revert test changes * last test update * update test name and snapshot * remove tests to expedite checkin
* Revert "FocusTrapZone does not correctly trap focus when last child is FocusZone (#4172)" This reverts commit 699fa69. * fix picker suggestions and add many tests * adding snap file * adding change file * improve test * fix tests and config * revert test changes * last test update * update test name and snapshot * undo suggestions change so it will merge properly * revert change to suggestions
* Temporarily disable tree shaking. * Adding change files.
* fix a few picker bugs related to scrolling and focus * adding change file
* dropdown role is listbox * change file
* Fixing async focus in scenarios where code was passing in component refs which have focus implemented. * Adding change file.
…e inversion (#4420) * fix strong variant * fix syntactic sugar * changefile * Update phkuo-betterStrong_2018-03-30-22-56.json * Update phkuo-betterStrong_2018-03-30-22-56.json
* fix display long title without spaces in DocumentCardTitle * change file
…th. (#4364) * Add interactable tooltip. * Fix merge issue. * Use the _async utility. * Used more _async
* Support NodeJS 9.* * Don't add scroll to popups with no height * Add change file
* Changes DetailsList to enable use of a basic Shimmer when default renderers are used. * Change log commit. * Comments out the use of DetailsList with the changes because breaks the build trying to import directly from the path provided. * Adds border bottom to shimmer rows when in default state. * Adds support for RTL layout plus small tweak in logic in DetailsRowFields. * Rename isShimmer to shimmer. Move _initialRenderItems to constructor. Change some language for enableShimmer description. * Adds type to rowProps constant. * Moved some styles to vars. * Moves the shimmerInitialItems to a constant. * Change the language for documentation of enableShimmer. * Add comment to example.
* Adding a longer delay as an option to the tooltip comonent. Before there was only a medium (300ms) or zero (0ms) delay. * change * Changing the delay to 500ms after talking to June
* Added IComponentAs to @utilities * added dividerAs prop to control breadcrumb prop * custom divider icon added to breadcrumb example page
* Fix tructation bug due to broken reference * Add change file
* fix css issues to allow more flexible header/footer buttons for consumers * change file
* Align Tiles in last row with previous rows * Add ability not to scroll Fabric examples * Update change output * Add comments and minor cleanup to TilesList
* Change fabric toolkit link * Add office toolkit blurb and link
…ons on small devices. (#4438) This change follows the precedent of calloutProps used for rendering options on other devices.
…epositioning logic (#4419) * Callout perf and quality of life improvements * adding change file * improve comment * adding in another comment * fix errors * update visibility so no visibility attribute is present if callout is visible * minor fix * update snapshots * change from 'isHidden' to 'hidden' * update comments * Removing whitespice
* Moved the pulsing beacon animation to styling * Added change file
The dialog inside Panel uses the panel header text as its ARIA label, referencing the header text element using `aria-labelledby=<header text id>`. That works fine with the default renderer, but custom renderers had no way to assign the correct ID, meaning the panel title was not read. As a fix, this PR adds an additional `headerTextId` param to the header renderer.
* Re-focus DatePicker input after calendar is closed * add change file * Fix PR mistake: used the wrong function
* Make comboBoxes wrap per the ATHEN feedback * add unit tests and account for a non-focusable element at the beginning/end of the list * rush change * update test comments * Add a test to check the wrapping with non-focusable content above
* FocusTrapZone: Add a keyDown prop * rush change
* changes to fix tooltip host overflow changes * Adding run file changes
…unctions (#4485) * OverflowSet: Add Foucs(firstChild) and focusElement() functions * rush change and clean the code up a bit * update to align implementation and the interface
…add some styling functions. (#4382) * Persona, PersonaCoin, and PersonaPresence now use mergeStyles. * Add noWrap general function * Replace `IPersonaProps` with `IPersonaSharedProps`. Extend shared props for Persona, PersonaCoin, and PersonaPresence. * Update test for decorated Persona * Fix high contrast styles, remove unused styles and consts * Organize, cleanup and add comments * Remove deprecated Placeholder className (not used) * Remove display: none styles from presenceIcon and instead just not render it. * Modify coinSize related consts to adhere to `IStyleSet`. * Split Icon into private render method to conditionally render. * Fix Image: `ImageFitStyles` for both RTL and LTR * Add backgroundClip to `IRawStyleBase` * Major cleanup: - Remove redundant code - Switch to system fonts only - Switch High Contrast colors to agreed new color scheme. - Available presence is now Highlight - All other presence are WindowText - Use semanticColors instead of palette colors - Blocked status match Fabric toolkit * Bump bundlesize .1kB
…e constructor (#4495) * moved the creation of split button containers into the constructor * addeed change file
* Split PersonaCoin * Split PersonaPresence * Move to sub-folders
* Exports an enum from Tile.tsx needed for ShimmerTile creation. * Change log. * Exports another const needed for ShimmerPlaceholderTile for values to be in one source. * Renames a SIZES to TileLayoutSizes.
* Fix IconButton styles for hover, focus, and pressed. * Switch to semanticColors
…4505) * Add TooltipHost types * Added change file * Updated text in change file * Add description to tooltip overview
* Add Button override to markdown
* Fix padding left and add padding top and bottom * Added change file * Updated snapshot
* Initial stab at documentation cleanup * Doc updates first iteration * Some more updates * Added FAQ * Fixed some links * Minor cleanup * more code review comments * SampleApp document * Fixed SampleApp link * Some final cleanup
* replace webpack-dev-server with a fast one; start using smarter ts-loader experimentalWatchApi * update package.json to use the officially updated webpack-dev-server * adding a forked ts checker plugin * make fork-ts-checker-webpack-plugin happen only on serve * Move to devtool: eval
* Ref updates. * Updating component refs.
* Changes the example to use enableShimmer of the DetailsList. * Rush change log.
* fixing focusZone algnment issue * updating snapshots * pushing a missed snapshot test * pulling from master, fixing test that was recently added that was broken * responding to david's comments * Update jolore-focusZoneUpdate_2018-04-07-00-43.json
* Broken import. * fixing import.
* Link: fix the style interface * Add change file. * Update susu-link-style-insterface-fix_2018-03-30-08-45.json
* Getting rid of extra asterisks * New required example and example styling * Added change file
* Setting up an example with shimmer tiles. * Adds some logic to fake some shimmer tiles. * Imports shimmer inside TileList. * Reuse the _getCells function to create fake Shimmer Tiles. * Break point before changing Tile. * Adds a Shimmer tile to Tile component. * Adds logic to Tile in case the content is not passed. * Refactors the example helpers and adds new proprietes to GridItem and GridSegment. * Refactors some logic. * Changes the logic for changes in TilesList. Moves getShimmerCell as a private member of Tile class. * Changes Tile 'shimmerPlaceholder' prop name to 'asPlaceholder'. Applies a different logic to the margin replaced by border. * Renames props and styles in Tile * Break point to test some new things. * Exports the TileLayoutValues enum. * Duplicate ShimmerLine to put basics for ShimmerGap. * Removes unnecessary checks and moves functions outside for re-usability. * Change the name of maxHeight to maxLineHeight for better semantics. * Extracts another function for reusability purposes. * Renames again a prop for semantics reasons. * Cleans up code. * Renames a prop for semantics. * Duplicates a folder as base for ShimmerTile component. * Sets up props for ShimmerTile * Exports a const for reusability. * Creates a new example for ShimmerTile. * Removes a file. * Adds initial elements for testing * Brings logic in TilesList and sets up an example. * Updates some styling in the TilesList example. * Change name of a constant for semantics. * Sets a checkbox to toggle sizes. Fixes Firefox border rounding decimal value of pixels. * Fixes build errors. * Rush change log. * Changes type 'JSX.Element[] | JSX.Elelment' to React.ReactNode. * Removes import. * Removes the import statement.
…menu (#4517) * SplitButton: Allow the primary portion of a splitButton (when it a menu) to collapse a submenu * rush change * Clear the submenu props off of the item when handling the hover events not on the expandable portion of the control. * Remove unneeeded comment update
* Update docs explaining the stale bot usage * Removed personal info
* Slow down stale bot until we complete our April triage sprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
(give an overview)
Focus areas to test
(optional)