Persona: mergeStyles part 3, split sub-components#4496
Persona: mergeStyles part 3, split sub-components#4496jordandrako merged 5 commits intomicrosoft:masterfrom
Conversation
|
@dzearing @oengusmacinog Should sub-components like PersonaCoin and PersonPresence live in their own folders like the Button folder structure to cut down on clutter? |
| export * from './Persona.base'; | ||
| export * from './Persona.types'; | ||
| export * from './PersonaCoin'; | ||
| export * from './PersonaCoin.base'; |
There was a problem hiding this comment.
probably want to add PersonaPresence.base too
There was a problem hiding this comment.
Left out for now as Persona.types export PersonaPresence enum so the names conflict. What are your thoughts on this:
export { PersonaPresence as PersonaPresenceIcon } from './PersonaPresence';
export { PersonaPresenceBase as PersonaPresenceIconBase } from './PersonaPresence.base';
oengusmacinog-zz
left a comment
There was a problem hiding this comment.
Just the one comment, I would go ahead and add presence base to index but otherwise looks good mate!
|
For File structure, I think what you have is good. Might start getting confusing as we scale, but essentially nested components would be intended to be subcomponents of the folder they are nested in, even though each sub-component can be used individually if desired. Still seems cleaner to structure this way, just should document some standards of when to nest and export a component |
Pull request checklist
$ npm run changeDescription of changes