Styling: Moved the pulsing beacon animation to styling for reuse#4446
Merged
lynamemi merged 2 commits intomicrosoft:masterfrom Apr 4, 2018
Merged
Styling: Moved the pulsing beacon animation to styling for reuse#4446lynamemi merged 2 commits intomicrosoft:masterfrom
lynamemi merged 2 commits intomicrosoft:masterfrom
Conversation
2 tasks
Collaborator
Author
|
@phkuo Sorry had to split up that other PR you approved yesterday - this is the same code for Styling, but without the changes to Coachmark. That will be a separate PR. |
phkuo
reviewed
Apr 4, 2018
| const DEFAULT_DELAY = '2s'; | ||
| const DEFAULT_ITERATION_COUNT = '1'; | ||
|
|
||
| function _continuousPulseStepOne(beaconColorOne: string, innerDimension: string): IRawStyle { |
Contributor
There was a problem hiding this comment.
I'm pretty sure you can have numbers in function names, it just can't start with a number.
phkuo
approved these changes
Apr 4, 2018
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Moved the pulsingBeacon animation from Coachmark into its own file in the Styling package. Let me know if it makes more sense to you to put it somewhere else.
I will be reusing this animation for ActivityItem. The design and behavior has not changed.
Focus areas to test
(optional)