TilesList: Implements new ShimmerTile into TilesList#4501
Merged
Vitalius1 merged 41 commits intomicrosoft:masterfrom Apr 11, 2018
Merged
TilesList: Implements new ShimmerTile into TilesList#4501Vitalius1 merged 41 commits intomicrosoft:masterfrom
Vitalius1 merged 41 commits intomicrosoft:masterfrom
Conversation
added 30 commits
March 30, 2018 18:08
… private member of Tile class.
…es a different logic to the margin replaced by border.
added 6 commits
April 9, 2018 15:15
…l value of pixels.
Member
|
I actually quite like what you've got in |
|
|
||
| this._classNames = getClassNames(getStyles!, { width, rowHeight, isDataLoaded, isBaseStyle }); | ||
|
|
||
| const renderedElements: JSX.Element[] | JSX.Element = getRenderedElements(lineElements, rowHeight); |
Member
There was a problem hiding this comment.
React.ReactNode can be used in place of JSX.Element[] | JSX.Element
Contributor
Author
There was a problem hiding this comment.
Thanks. Implemented!
ThomasMichon
approved these changes
Apr 10, 2018
…/office-ui-fabric-react into v-vibr/PlaceholderTile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Focus areas to test
https://odsp-int.azurewebsites.net/v-vibr/TilesList/#/examples/tileslist
Here would be an example setup in the TilesList page.