Panel: pass ID for header text element to custom renderer#4469
Merged
ecraig12345 merged 6 commits intomicrosoft:masterfrom Apr 5, 2018
Merged
Panel: pass ID for header text element to custom renderer#4469ecraig12345 merged 6 commits intomicrosoft:masterfrom
ecraig12345 merged 6 commits intomicrosoft:masterfrom
Conversation
joschect
reviewed
Apr 5, 2018
| </div> | ||
| <div className={ css('ms-Panel-contentInner', styles.contentInner) } > | ||
| { onRenderHeader(this.props, this._onRenderHeader) } | ||
| { onRenderHeader(this.props, this._onRenderHeader, headerTextId) } |
Contributor
There was a problem hiding this comment.
nit: it should match popup, with headerText && headerTextId. An optional change though.
joschect
approved these changes
Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The dialog inside Panel uses the panel header text as its ARIA label, referencing the header text element using
aria-labelledby=<header text id>. That works fine with the default renderer, but custom renderers had no way to assign the correct ID, meaning the panel title was not read.As a fix, this PR adds an additional
headerTextIdparam to the header renderer.