Skip to content

DatePicker: Required field asterisk bug fix#4456

Merged
lorejoh12 merged 3 commits intomicrosoft:masterfrom
lynamemi:picker-required
Apr 11, 2018
Merged

DatePicker: Required field asterisk bug fix#4456
lorejoh12 merged 3 commits intomicrosoft:masterfrom
lynamemi:picker-required

Conversation

@lynamemi
Copy link
Copy Markdown
Collaborator

@lynamemi lynamemi commented Apr 4, 2018

Pull request checklist

Description of changes

DatePicker was rendering two extra icons for required fields: One after the label, one after the input field, and one under the input if no error message is specified:
image

  • Using TextField's label because TextField already has the support to add an icon only after the label, if there is one, or only after the input field, if there is no label.
  • Removing the asterisks that replace error message. Need to have the blank space in the string to pick up the error message styling on the input field.
  • Added a new 'required' example to show these two variants.
  • Added example styling that matches the TextField example page (improves legibility with width and spacing).

After:
image

Focus areas to test

(optional)

@lynamemi lynamemi requested a review from lorejoh12 as a code owner April 4, 2018 18:16
@lynamemi lynamemi changed the title Picker required DatePicker: Required field asterisk bug fix Apr 4, 2018
@lorejoh12 lorejoh12 merged commit 82e1f0f into microsoft:master Apr 11, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DatePicker - Extra required indicator (*)

2 participants